Skip to content

Add Terms of Use notice to welcome banner#6866

Open
Arpan200502 wants to merge 1 commit intoopenstreetmap:masterfrom
Arpan200502:feature-tou-welcome-banner
Open

Add Terms of Use notice to welcome banner#6866
Arpan200502 wants to merge 1 commit intoopenstreetmap:masterfrom
Arpan200502:feature-tou-welcome-banner

Conversation

@Arpan200502
Copy link
Contributor

@Arpan200502 Arpan200502 commented Mar 5, 2026

Closes #6791

Adds a Terms of Use notice to the welcome banner displayed to unauthenticated users on the map page.

Implementation details:

  • Added a new translation string layouts.welcome_tou_notice_html in config/locales/en.yml.
  • Appended the notice to the existing welcome banner in app/views/layouts/map.html.erb.
  • Kept layouts.hosting_partners_2024_html unchanged since it is reused on other pages.

The notice includes a link to the Terms of Use.

Pointing towards https://osmfoundation.org/wiki/Terms_of_Use
image

@Arpan200502 Arpan200502 force-pushed the feature-tou-welcome-banner branch from 761720e to 5aa62d1 Compare March 6, 2026 03:00
@Arpan200502 Arpan200502 force-pushed the feature-tou-welcome-banner branch from 5aa62d1 to a4d3e52 Compare March 6, 2026 15:40
@Arpan200502 Arpan200502 requested a review from hlfan March 6, 2026 15:40
@Arpan200502 Arpan200502 force-pushed the feature-tou-welcome-banner branch from a4d3e52 to 55a1f8f Compare March 7, 2026 08:39
@Arpan200502 Arpan200502 requested a review from hlfan March 7, 2026 08:40
@pablobm
Copy link
Contributor

pablobm commented Mar 9, 2026

Pinging @1ec5 for an opinion.

@pablobm
Copy link
Contributor

pablobm commented Mar 10, 2026

Any opinions on the terms paragraph using a slightly smaller font (fs-7) than the other paragraphs (fs-6)? In the original issue, @1ec5 commented:

To avoid making the banner too large, especially on mobile devices, we could make the second paragraph smaller (like it used to be, I think) and append the new text to that paragraph.

Which I initially understood as shortening the copy, but perhaps this is what was meant?

@1ec5
Copy link
Collaborator

1ec5 commented Mar 10, 2026

Yes, I was referring to using a smaller font for the partners paragraph, not shortening the text in it. The addition of this paragraph didn’t add as much vertical space as I feared, at least in English, but setting the partners paragraph in the same smaller font would help highlight the site description, which is more interesting to visitors anyways.

@Arpan200502
Copy link
Contributor Author

Arpan200502 commented Mar 12, 2026

Yes, I was referring to using a smaller font for the partners paragraph, not shortening the text in it. The addition of this paragraph didn’t add as much vertical space as I feared, at least in English, but setting the partners paragraph in the same smaller font would help highlight the site description, which is more interesting to visitors anyways.

@pablobm @1ec5
Yes, that was my intention as well. I kept the Terms of Use paragraph in fs-7 so it matches the existing partners paragraph and keeps the main site description visually emphasized.

If you'd prefer merging the text into the same paragraph instead, I can adjust that.

@Arpan200502 Arpan200502 requested review from 1ec5 and pablobm March 12, 2026 09:46
Comment on lines 40 to 42
:corpmembers => link_to(t("layouts.partners_corpmembers"), "https://osmfoundation.org/wiki/Corporate_Members"),
:partners => link_to(t("layouts.partners_partners"), "https://hardware.openstreetmap.org/thanks/") %>
</p>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to combine the paragraphs, but let’s switch this paragraph to fs-7 fw-light also, since they’re both less critical to the banner’s message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Communicate Terms of Use to unauthenticated users

4 participants