Skip to content

Rename heatmap label to Contribution Calendar#6932

Open
Arpan200502 wants to merge 1 commit intoopenstreetmap:masterfrom
Arpan200502:rename-heatmap-to-contribution-calendar
Open

Rename heatmap label to Contribution Calendar#6932
Arpan200502 wants to merge 1 commit intoopenstreetmap:masterfrom
Arpan200502:rename-heatmap-to-contribution-calendar

Conversation

@Arpan200502
Copy link
Contributor

Closes #6849

This PR renames the user-facing "Heatmap" feature in the profile section to "Contribution Calendar" to better reflect its purpose as a temporal activity overview (similar to GitHub’s contribution graph), rather than a geographic heatmap.

Changes

  • Updated user-facing labels from "Heatmap" → "Contribution Calendar"
  • Updated relevant i18n keys in config/locales/en.yml
  • Renamed related translation keys (e.g., edit_heatmapedit_contribution_calendar, show_heatmap_in_publicshow_contribution_calendar_in_public)
  • Updated success messages and UI text accordingly
  • Updated controller tests to reflect new text
  • Preserved the existing heatmaps namespace to maintain correct Rails i18n scoping and avoid breaking relative lookups

Notes

  • Based on reviewer feedback, translation keys were updated while keeping namespace structure intact
  • Changes are limited to en.yml as other locales are managed externally via TranslateWiki

Previous PR

This replaces #6884.

The previous PR was unintentionally closed after a rebase operation temporarily aligned the branch with master, resulting in no diff. Since GitHub treats such branches as having no changes, the PR was automatically closed and could not be reopened once the history diverged again.

This PR restores the intended changes with a clean, linear commit history.

@Arpan200502 Arpan200502 force-pushed the rename-heatmap-to-contribution-calendar branch 2 times, most recently from f8ef052 to a2838c0 Compare March 24, 2026 17:48
@Arpan200502 Arpan200502 force-pushed the rename-heatmap-to-contribution-calendar branch from a2838c0 to 44f8ae7 Compare March 24, 2026 17:57
@Arpan200502 Arpan200502 force-pushed the rename-heatmap-to-contribution-calendar branch from 44f8ae7 to 824b23a Compare March 24, 2026 18:01
@Arpan200502 Arpan200502 requested a review from hlfan March 24, 2026 18:04
@Arpan200502 Arpan200502 force-pushed the rename-heatmap-to-contribution-calendar branch from 824b23a to 1600641 Compare March 24, 2026 18:41
@Arpan200502 Arpan200502 force-pushed the rename-heatmap-to-contribution-calendar branch from 1600641 to 427aca5 Compare March 24, 2026 18:53
@Arpan200502 Arpan200502 force-pushed the rename-heatmap-to-contribution-calendar branch from 427aca5 to 8c25224 Compare March 24, 2026 19:04
@Arpan200502 Arpan200502 force-pushed the rename-heatmap-to-contribution-calendar branch from 8c25224 to 1320939 Compare March 24, 2026 19:14
@Arpan200502 Arpan200502 requested a review from hlfan March 24, 2026 19:16
@hlfan hlfan requested a review from 1ec5 March 24, 2026 19:58
@Arpan200502 Arpan200502 force-pushed the rename-heatmap-to-contribution-calendar branch from 1320939 to e881ea6 Compare March 25, 2026 06:34
@Arpan200502 Arpan200502 requested a review from hlfan March 25, 2026 06:44
@hlfan hlfan removed their request for review March 25, 2026 06:45
@pablobm
Copy link
Contributor

pablobm commented Mar 25, 2026

I think this is almost there. There's just the detail of the capitalisation. I think there has been both a misunderstanding and an ambiguity. Let's see if we can clarify all this.

  1. At Rename heatmap label to Contribution Calendar #6932 (comment), I think there's a misunderstanding by @Arpan200502. The comment is about how "heatmap" was replaced with "Contribution Calendar". In that specific instance, there's an inconsistency: it goes from non-capitalised to capitalised.
  2. At Rename heatmap label to Contribution Calendar #6932 (comment) however, there's an ambiguity. "Heatmap" is replaced with "Contribution Calendar", which is not necessarily wrong. We go from a single-word noun, capitalised, to a two-word noun whose capitalisation we haven't discussed: should it be capitalised as "Contribution Calendar" or as "Contribution calendar"?

Personally, I think it should be "Contribution Calendar" in all instances. This is even for the uncapitalised "heatmap" one which I think was a prior mistake as it refers to a distinct entity in the UI that should be capitalised, as opposed to a general term that could refer to many things.

Also: @Arpan200502, when offered feedback, please don't just accept it blindly. Stop for a moment, think about what you are being asked, and reason about what to do. If you think that some things should stay as they are, they do say so and explain your rationale. Part of the job of a Software Engineer is to push back when it makes sense.

@tomhughes
Copy link
Member

Well as I was reading it the previous behaviour was that is was capitalised when used in a title (where all main words were capitalised) or at the start of a sentence.

I was aiming to preserve that, so capitalise both words in a title, the first word at the start of a sentence, and neither in the middle of a sentence.

@pablobm
Copy link
Contributor

pablobm commented Mar 25, 2026

Oh, title case. I hate title case 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename heatmap feature

5 participants