Rename heatmap label to Contribution Calendar#6932
Rename heatmap label to Contribution Calendar#6932Arpan200502 wants to merge 1 commit intoopenstreetmap:masterfrom
Conversation
f8ef052 to
a2838c0
Compare
a2838c0 to
44f8ae7
Compare
44f8ae7 to
824b23a
Compare
824b23a to
1600641
Compare
1600641 to
427aca5
Compare
427aca5 to
8c25224
Compare
8c25224 to
1320939
Compare
1320939 to
e881ea6
Compare
|
I think this is almost there. There's just the detail of the capitalisation. I think there has been both a misunderstanding and an ambiguity. Let's see if we can clarify all this.
Personally, I think it should be "Contribution Calendar" in all instances. This is even for the uncapitalised "heatmap" one which I think was a prior mistake as it refers to a distinct entity in the UI that should be capitalised, as opposed to a general term that could refer to many things. Also: @Arpan200502, when offered feedback, please don't just accept it blindly. Stop for a moment, think about what you are being asked, and reason about what to do. If you think that some things should stay as they are, they do say so and explain your rationale. Part of the job of a Software Engineer is to push back when it makes sense. |
|
Well as I was reading it the previous behaviour was that is was capitalised when used in a title (where all main words were capitalised) or at the start of a sentence. I was aiming to preserve that, so capitalise both words in a title, the first word at the start of a sentence, and neither in the middle of a sentence. |
|
Oh, title case. I hate title case 😆 |
Closes #6849
This PR renames the user-facing "Heatmap" feature in the profile section to "Contribution Calendar" to better reflect its purpose as a temporal activity overview (similar to GitHub’s contribution graph), rather than a geographic heatmap.
Changes
config/locales/en.ymledit_heatmap→edit_contribution_calendar,show_heatmap_in_public→show_contribution_calendar_in_public)heatmapsnamespace to maintain correct Rails i18n scoping and avoid breaking relative lookupsNotes
en.ymlas other locales are managed externally via TranslateWikiPrevious PR
This replaces #6884.
The previous PR was unintentionally closed after a rebase operation temporarily aligned the branch with
master, resulting in no diff. Since GitHub treats such branches as having no changes, the PR was automatically closed and could not be reopened once the history diverged again.This PR restores the intended changes with a clean, linear commit history.