Skip to content

chore(core): Add Github Copilot and Gemini as reviewers#2346

Closed
jrschumacher wants to merge 1 commit into
mainfrom
add-ai-reviewers-on-pr
Closed

chore(core): Add Github Copilot and Gemini as reviewers#2346
jrschumacher wants to merge 1 commit into
mainfrom
add-ai-reviewers-on-pr

Conversation

@jrschumacher

Copy link
Copy Markdown
Member

Proposed Changes

  • Add Github Copilot as reviewer
  • Ask Gemini to review

Checklist

  • I have added or updated unit tests
  • I have added or updated integration tests (if appropriate)
  • I have added or updated documentation

Testing Instructions

@jrschumacher jrschumacher requested review from a team as code owners June 2, 2025 18:37
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@github-actions github-actions Bot added the comp:ci Github Actions Work label Jun 2, 2025
@github-actions

github-actions Bot commented Jun 2, 2025

Copy link
Copy Markdown
Contributor

/gemini review

@github-actions github-actions Bot added the size/s label Jun 2, 2025
@jrschumacher

Copy link
Copy Markdown
Member Author

Github uses a built in setting

@github-actions

github-actions Bot commented Jun 2, 2025

Copy link
Copy Markdown
Contributor
Benchmark results, click to expand

Benchmark authorization.GetDecisions Results:

Metric Value
Approved Decision Requests 5000
Denied Decision Requests 0
Total Time 439.632216ms

Benchmark authorization.v2.GetMultiResourceDecision Results:

Metric Value
Approved Decision Requests 5000
Denied Decision Requests 0
Total Time 301.144667ms

Bulk Benchmark Results

Metric Value
Total Decrypts 100
Successful Decrypts 100
Failed Decrypts 0
Total Time 346.261526ms
Throughput 288.80 requests/second

TDF3 Benchmark Results:

Metric Value
Total Requests 5000
Successful Requests 5000
Failed Requests 0
Concurrent Requests 50
Total Time 51.038839271s
Average Latency 507.81494ms
Throughput 97.96 requests/second

NANOTDF Benchmark Results:

Metric Value
Total Requests 5000
Successful Requests 4948
Failed Requests 52
Concurrent Requests 50
Total Time 45.792189994s
Average Latency 452.610309ms
Throughput 108.05 requests/second

Error Summary:

Error Message Occurrences
ReadNanoTDF error: getNanoRewrapKey: rewrapError: internal: internal error
rpc error: code = Internal desc = could not perform access
52 occurrences

Standard Benchmark Metrics Skipped or Failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp:ci Github Actions Work size/s

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant