fix(deps): bump protocol/go to 0.37.0 and sdk to 0.26.0 in /service#3721
fix(deps): bump protocol/go to 0.37.0 and sdk to 0.26.0 in /service#3721alkalescent wants to merge 1 commit into
Conversation
Signed-off-by: Krish Suchak <suchak.krish@gmail.com>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the OpenTDF module dependencies within the service directory to their latest versions. These changes ensure that the service module remains compatible with the current workspace configuration and satisfies the release-branch build requirements, effectively unblocking the upcoming service release. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. The modules were pinned far too low, / We needed the versions to grow. / With thirty-seven and twenty-six, / We gave the build pipeline a fix, / And now the release is a go. Footnotes
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR bumps two direct Go module dependencies in ChangesDependency Bump
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request updates the dependencies in service/go.mod and service/go.sum, upgrading github.com/opentdf/platform/protocol/go to version v0.37.0 and github.com/opentdf/platform/sdk to version v0.26.0. I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Benchmark results, click to expandBenchmark authorization.GetDecisions Results:
Benchmark authorization.v2.GetMultiResourceDecision Results:
Benchmark Statistics
Bulk Benchmark Results
TDF3 Benchmark Results:
|
|
Summary
Bumps the two OpenTDF module pins in
service/go.modto their latest releases:github.com/opentdf/platform/protocol/gov0.36.0 → v0.37.0github.com/opentdf/platform/sdkv0.25.0 → v0.26.0main's service code already referencesprotocol/gov0.37.0sdkconnecttypes, so the module builds in the workspace but cannot be released at the old pins: the release-branch guard (.github/scripts/work-init.sh) builds each module against its pinned deps and fails. This bump makes the service module releasable and gives the in-flight service feature PRs a releasable base.Only
service/go.modandservice/go.sumchange (viago get+go mod tidy).Notes
protocol/gofor/service.Testing
GOWORK=off go build ./...inservice/passes (mirrors the pinned-deps release guard).Summary by CodeRabbit