Fix typo in How to use it #42
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
recheck |
Nils-Magnus
suggested changes
Jan 8, 2024
Nils-Magnus
left a comment
Nils-Magnus
left a comment
There was a problem hiding this comment.
The upstream bug is a one-char typo. That LGTM.
However in the meantime five updates (see plugins/modules/github_org_repository.py) of a inherited class sneaked in and are apparently expect its attributes to be [] instead of None:
contextsrestrictionsteamstopics
-users
2024-01-04 10:58:23.254052 | fedora-pod | ERROR: Found 5 validate-modules issue(s) which need to be resolved:
2024-01-04 10:58:23.254097 | fedora-pod | ERROR: plugins/modules/github_org_repository.py:0:0: doc-default-does-not-match-spec: Argument 'contexts' in argument_spec found in branch_protections -> required_status_checks defines default as (None) but documentation defines default as ([])
2024-01-04 10:58:23.254104 | fedora-pod | ERROR: plugins/modules/github_org_repository.py:0:0: doc-default-does-not-match-spec: Argument 'restrictions' in argument_spec found in branch_protections defines default as ({}) but documentation defines default as (None)
2024-01-04 10:58:23.254109 | fedora-pod | ERROR: plugins/modules/github_org_repository.py:0:0: doc-default-does-not-match-spec: Argument 'teams' in argument_spec found in branch_protections -> required_pull_request_reviews -> dismissal_restrictions defines default as (None) but documentation defines default as ([])
2024-01-04 10:58:23.254115 | fedora-pod | ERROR: plugins/modules/github_org_repository.py:0:0: doc-default-does-not-match-spec: Argument 'topics' in argument_spec defines default as ([]) but documentation defines default as (None)
2024-01-04 10:58:23.254119 | fedora-pod | ERROR: plugins/modules/github_org_repository.py:0:0: doc-default-does-not-match-spec: Argument 'users' in argument_spec found in branch_protections -> required_pull_request_reviews -> dismissal_restrictions defines default as (None) but documentation defines default as ([])
2024-01-04 10:58:23.254124 | fedora-pod | See documentation for help: https://docs.ansible.com/ansible-core/2.16/dev_guide/testing/sanity/validate-modules.html
Contributor
|
Branch needs a update, @gtema repaired the eco-checks :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.