Hotkey splitting

[open-junius]

Description

Related Issue(s)

• Closes Hotkey Splitting (Per-Subnet Hotkey Swap) #1524

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation update
• Other (please describe):

Breaking Change

If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.

Checklist

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

Screenshots (if applicable)

Please include any relevant screenshots or GIFs that demonstrate the changes made.

Additional Notes

Please provide any additional information or context that may be helpful for reviewers.

[JohnReedV]

The validate-benchmarks job runs the benchmarks and then compares the result to what is written in the extrinsic's definition. It doesn't currently support DispatchResultWithPostInfo.

To get it to pass you can either update the reads/writes in the dispatch or add the skip-validate-benchmarks label to this PR.

[ts-paulswaim]

Did the nonce fix get reverted/regressed in Bittensor? Nonce issue for setting weights on hotkey was addressed there a while back, regressed in Feb, then fixed again.
opentensor/bittensor#2534
Not opposed to this, but it had something addressing it at Bittensor layer.

• This would also trigger identity fees on all subnets for valis using one hotkey atm.
• How does this appear to stakers when looking for staking options?

[open-junius]

Did the nonce fix get reverted/regressed in Bittensor? Nonce issue for setting weights on hotkey was addressed there a while back, regressed in Feb, then fixed again. opentensor/bittensor#2534 Not opposed to this, but it had something addressing it at Bittensor layer.

• This would also trigger identity fees on all subnets for valis using one hotkey atm.
• How does this appear to stakers when looking for staking options?

Can you elaborate your comment? can't understand it. Did you suggest any code change in Bittensor?

[ts-paulswaim]

Did the nonce fix get reverted/regressed in Bittensor? Nonce issue for setting weights on hotkey was addressed there a while back, regressed in Feb, then fixed again. opentensor/bittensor#2534 Not opposed to this, but it had something addressing it at Bittensor layer.

• This would also trigger identity fees on all subnets for valis using one hotkey atm.
• How does this appear to stakers when looking for staking options?

Can you elaborate your comment? can't understand it. Did you suggest any code change in Bittensor?

This PR's original issue mentioned resolving the fact that a single hotkey used as a validator across all subnets suffered from an inability to set weights consistently (related to nonces and transaction pools?). The link I provided was a resolution for that issue at the Bittensor level, not Subtensor, so I was unsure why this was being raised unless that fix regressed.
Original issue mentioned several things, but this was the item I mentioned above:
"Due to a ratelimits, validators can only set weights from one hotkey on one subnet in any given block."

[open-junius]

Did the nonce fix get reverted/regressed in Bittensor? Nonce issue for setting weights on hotkey was addressed there a while back, regressed in Feb, then fixed again. opentensor/bittensor#2534 Not opposed to this, but it had something addressing it at Bittensor layer.

• This would also trigger identity fees on all subnets for valis using one hotkey atm.
• How does this appear to stakers when looking for staking options?

Can you elaborate your comment? can't understand it. Did you suggest any code change in Bittensor?

This PR's original issue mentioned resolving the fact that a single hotkey used as a validator across all subnets suffered from an inability to set weights consistently (related to nonces and transaction pools?). The link I provided was a resolution for that issue at the Bittensor level, not Subtensor, so I was unsure why this was being raised unless that fix regressed. Original issue mentioned several things, but this was the item I mentioned above: "Due to a ratelimits, validators can only set weights from one hotkey on one subnet in any given block."

My understanding for the solution is the new netuid parameter give the coldkey ability to swap hotkey in any subnet. It will remove the limit of tx rate. also save the cost to register hotkey in every subnet.
Please @ppolewicz give more context about it, and provide precise answer