Skip to content

Adds new move_stake_limit extrinsic #1583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: devnet-ready
Choose a base branch
from

Conversation

mcjkula
Copy link

@mcjkula mcjkula commented Apr 30, 2025

Description

Adds new move_stake_limit extrinsic.

Related Issue(s)

  • Closes #[issue number]

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Breaking Change

If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots (if applicable)

Please include any relevant screenshots or GIFs that demonstrate the changes made.

Additional Notes

Please provide any additional information or context that may be helpful for reviewers.

@mcjkula
Copy link
Author

mcjkula commented Apr 30, 2025

I would hope someone can look through my code, test if everything works and help with the PR. Would highly appreciate it!

@open-junius
Copy link
Contributor

pls check this one https://github.com/opentensor/subtensor/blob/main/pallets/subtensor/src/macros/dispatches.rs#L1869. looks like it is already implemented.

@mcjkula
Copy link
Author

mcjkula commented May 1, 2025

swapStake and moveStake are different though, because with swapStake you can only move from subnet to subnet with the same cold- and hotkey, while moveStake allows you to move from subnet to subnet with any hotkey (or just move stake from hotkey to hotkey in the same subnet). @open-junius

Depending on how you would handle such case it would make sense to either change moveStake to only allow changing between hotkeys in the same subnet, or remove swapStake as its just a subset of what moveStake does. (or we let them both co-exist as they are)

@camfairchild camfairchild added skip-cargo-audit This PR fails cargo audit but needs to be merged anyway and removed skip-cargo-audit This PR fails cargo audit but needs to be merged anyway labels May 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants