Clear epoch values for root subnets. #1658
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
run-bittensor-e2e-tests
gztensor
requested changes
May 20, 2025
| use alloc::string::String; | ||
| use frame_support::{traits::Get, weights::Weight}; | ||
|
|
||
| // List of cleared maps for root netuid: |
There was a problem hiding this comment.
We still need these values for root:
SubnetworkN
Tempo
Keys
MaxAllowedValidators
SubnetOwnerHotkey
BlockAtRegistration
This was referenced May 21, 2025
shamil-gadelshin
added
the
skip-cargo-audit
l0r1s
reviewed
May 21, 2025
Comment on lines
117
to
+120
| // Migrate ColdkeySwapScheduled structure to new format | ||
| .saturating_add(migrations::migrate_coldkey_swap_scheduled::migrate_coldkey_swap_scheduled::<T>()); | ||
| .saturating_add(migrations::migrate_coldkey_swap_scheduled::migrate_coldkey_swap_scheduled::<T>()) | ||
| // Clear epoch storage values for root netuid | ||
| .saturating_add(migrations::migrate_clear_root_epoch_values::migrate_clear_root_epoch_values::<T>()); |
There was a problem hiding this comment.
I think we should wait for #1660 to be merged because the weights are not accounted for atm
gztensor
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes values for root subnets from the following storage item list:
Related Issue(s)
Type of Change
Checklist
cargo fmtandcargo clippyto ensure my code is formatted and linted correctly