Introduce stake lock after add_stake operation. #1666
Draft
+55
−3,022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shamil-gadelshin
added
breaking-change
|
@opentensor/cerebrum / @opentensor/gyrus / @opentensor/cortex breaking change detected! Please prepare accordingly! |
|
cc @ppolewicz |
gztensor
requested changes
May 28, 2025
| return Ok(()); | ||
| } | ||
|
|
||
| let stake_lock = StakeLocks::<T>::get(hotkey, netuid); |
There was a problem hiding this comment.
I suggest that we remove the key here if lock is expired.
| @@ -1176,6 +1094,19 @@ pub mod pallet { | |||
| pub type TokenSymbol<T: Config> = | |||
| StorageMap<_, Identity, u16, Vec<u8>, ValueQuery, DefaultUnicodeVecU8<T>>; | |||
|
|
|||
| #[pallet::storage] | |||
| /// DMAP ( hot, netuid ) --> lock until block number | Returns the block number of the stake lock | |||
| pub type StakeLocks<T: Config> = StorageDoubleMap< | |||
There was a problem hiding this comment.
The stake locks should be by hotkey, coldkey, and netuid. Otherwise, we will be locking all nominators (all coldkeys) as soon as one coldkey stakes to this hotkey and nobody will be able to unstake until the next epoch.
Also, what happens if a coldkey has a 1000 TAO stake with expired lock and adds 1 TAO more? Should we keep them from unlocking only 1 TAO or the whole 1001 TAO amount?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the stake manipulation problem. It introduces a stake lock after each stake deposit operation (like
add_stakeoradd_stake_limit). The lock is the block number after which stake removal is allowed. It calculates as "current_block + subnet tempo".It relates to both MEV and "stake delta" problems.
The PR removes the commented code related to #1641 in the first commit.
Related Issue(s)
Type of Change
Breaking Change
Code that removes the stake immediately will stop working.
Checklist
cargo fmtandcargo clippyto ensure my code is formatted and linted correctly