fix: add missing RootClaim to ProxyType TryFrom<u8> #2295
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kunka0723
force-pushed
the
fix/proxy-type-root-claim
branch
from
96a7397 to
e64da20
Compare
camfairchild
approved these changes
Dec 16, 2025
Contributor
There is PR to add it. https://github.com/opentensor/subtensor/pull/2207/files#diff-d38884f7391ae50f795707dbb281656e8afe38ea3ecac15a6ee80d52724017c0R187. |
camfairchild
suggested changes
Dec 16, 2025
Contributor
camfairchild
left a comment
camfairchild
left a comment
There was a problem hiding this comment.
please use the correct base branch
Contributor
|
Thank you very much for the contribution. Now #2207 is merged. Could you please close the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
RootClaimvariant was missing from theTryFrom<u8>implementation forProxyType.This adds
17 => Ok(Self::RootClaim)to match the enum definition.