MevShield Emit Failure Event on Pre-Dispatch Failures #2340
+42
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnReedV
added
the
skip-cargo-audit
l0r1s
approved these changes
Jan 13, 2026
Collaborator
|
we care about btcli e2e tests already |
ales-otf
approved these changes
Jan 13, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently the
MevShieldpallet will emit an event in the case that decryption of the inner extrinsic fails or if the inner extrinsic results in a runtime error.This PR adds logic to emit the failure event in the case that the inner extrinsic fails on a pre-dispatch check such as the inability to pay the fee.
Requires node upgrades to work.