Skip to content

[ncp] add ncp_cli_join_leave.exp for CLI testing under NCP mode#2821

Merged
jwhui merged 2 commits into
openthread:mainfrom
yangsong-cnyn:ncp_cli_test
Apr 28, 2025
Merged

[ncp] add ncp_cli_join_leave.exp for CLI testing under NCP mode#2821
jwhui merged 2 commits into
openthread:mainfrom
yangsong-cnyn:ncp_cli_test

Conversation

@yangsong-cnyn
Copy link
Copy Markdown
Contributor

@yangsong-cnyn yangsong-cnyn commented Apr 25, 2025

This PR introduces a new expect test script, ncp_cli_join_leave.exp, designed to verify the functionality of joining and leaving using the ot-ctl CLI under NCP mode.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.74%. Comparing base (2b41187) to head (6b3b60f).
Report is 1034 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2821       +/-   ##
===========================================
- Coverage   55.77%   43.74%   -12.04%     
===========================================
  Files          87      114       +27     
  Lines        6890    13919     +7029     
  Branches        0      982      +982     
===========================================
+ Hits         3843     6089     +2246     
- Misses       3047     7508     +4461     
- Partials        0      322      +322     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yangsong-cnyn yangsong-cnyn force-pushed the ncp_cli_test branch 2 times, most recently from 710091b to 8514b84 Compare April 25, 2025 10:25
Copy link
Copy Markdown
Contributor

@Irving-cl Irving-cl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

A small issue. Add please update the PR title and description.

Comment thread tests/scripts/ncp_mode Outdated
@yangsong-cnyn yangsong-cnyn changed the title [ncp] use ot-ctl CLI for NCP join/leave test [ncp] add ncp_cli_join_leave.exp for CLI testing under NCP mode Apr 25, 2025
@yangsong-cnyn yangsong-cnyn requested a review from jwhui April 25, 2025 10:34
@jwhui jwhui requested a review from Copilot April 28, 2025 16:42
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (3)
  • tests/scripts/expect/_common.exp: Language not supported
  • tests/scripts/expect/ncp_cli_join_leave.exp: Language not supported
  • tests/scripts/ncp_mode: Language not supported

@jwhui jwhui merged commit bff98e0 into openthread:main Apr 28, 2025
49 of 54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants