[ncp] add ncp_cli_join_leave.exp for CLI testing under NCP mode#2821
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2821 +/- ##
===========================================
- Coverage 55.77% 43.74% -12.04%
===========================================
Files 87 114 +27
Lines 6890 13919 +7029
Branches 0 982 +982
===========================================
+ Hits 3843 6089 +2246
- Misses 3047 7508 +4461
- Partials 0 322 +322 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
710091b to
8514b84
Compare
Irving-cl
approved these changes
Apr 25, 2025
Contributor
Irving-cl
left a comment
There was a problem hiding this comment.
LGTM 👍
A small issue. Add please update the PR title and description.
ncp_cli_join_leave.exp for CLI testing under NCP mode
8514b84 to
a0a5c63
Compare
a0a5c63 to
adc0b14
Compare
adc0b14 to
62181b5
Compare
jwhui
approved these changes
Apr 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a new expect test script,
ncp_cli_join_leave.exp, designed to verify the functionality of joining and leaving using theot-ctlCLI under NCP mode.