Skip to content

[script] use new trusted public URL to download slc_cli zip files - #1196

Merged
jwhui merged 1 commit into
openthread:mainfrom
SiliconLabs:bugfix/slc-artifact-changes
Aug 21, 2025
Merged

[script] use new trusted public URL to download slc_cli zip files#1196
jwhui merged 1 commit into
openthread:mainfrom
SiliconLabs:bugfix/slc-artifact-changes

Conversation

@suveshpratapa

@suveshpratapa suveshpratapa commented Aug 21, 2025

Copy link
Copy Markdown
Member

Additionally add some slc debug logging.

This should address the current failures on ot-efr32 builds and unblock PRs.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @suveshpratapa, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the bootstrap_silabs script to use a new, publicly accessible URL for downloading slc_cli zip files. This change ensures that the script fetches the necessary files from a trusted public source, improving accessibility and reliability for the download process.

Highlights

  • Updated SLC CLI Download URL: The bootstrap_silabs script, specifically within the install_slc_cli function, has been updated to use a new URL for downloading slc_cli zip files. The change involves switching the path segment from /login/ to /public/ in the download URL.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly updates the download URL for the slc_cli tool to a public endpoint, which should resolve potential download issues. My review focuses on improving the security of the script. I've added one comment suggesting the implementation of a checksum verification for the downloaded file to protect against tampering or corruption.

Comment thread script/bootstrap_silabs
@suveshpratapa
suveshpratapa force-pushed the bugfix/slc-artifact-changes branch 16 times, most recently from 6cad7b9 to b4a6482 Compare August 21, 2025 19:12

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates the Silicon Labs SLC CLI download mechanism to use a new trusted public URL and adds debugging capabilities to troubleshoot current build failures on ot-efr32 platforms.

Key changes include:

  • Switches SLC CLI download URL from login-protected to public endpoint
  • Adds comprehensive debug logging for SLC environment variables and error logs
  • Updates Java runtime dependency from OpenJDK 17 to OpenJDK 21

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
script/bootstrap_silabs Updates SLC CLI download URL to use public endpoint instead of login-protected one
script/slc_cli Adds environment variable debugging output for SLC execution troubleshooting
script/generate Implements error log collection and display for failed SLC operations
script/bootstrap Updates Java dependency from OpenJDK 17 to OpenJDK 21

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread script/generate
Comment thread script/slc_cli

@romacdon romacdon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jwhui jwhui left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍🏼

@jwhui
jwhui merged commit e8e2545 into openthread:main Aug 21, 2025
8 checks passed
@suveshpratapa
suveshpratapa deleted the bugfix/slc-artifact-changes branch August 23, 2025 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants