feat: attr element function#3149
Closed
LeoTKBR wants to merge 28 commits into
Closed
Conversation
Auto Sync Fork
|
Contributor
|
This PR is stale because it has been open 45 days with no activity. |
majestyotbr
changed the title
majestyotbr
changed the title
Contributor
|
This PR is stale because it has been open 45 days with no activity. |
|
Contributor
|
This PR is stale because it has been open 45 days with no activity. |
|
Working perfectly Before After |
|
Just to note: It is not possible to remove (set to zero) the elemental attack of a weapon, unlike attr attack, which allows zero |
vllsystems
approved these changes
Apr 23, 2025
vllsystems
left a comment
vllsystems
left a comment
Contributor
There was a problem hiding this comment.
Tested on data-canary.
Windows 10.
Compiled with CMake.
Contributor
Author
|
Code fixed and reposted in a new PR: #3518 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With these modifications it will be possible to change the value of the weapon element through the attr command or via the lua command using the function: ITEM_ATTRIBUTE_ELEMENT