Skip to content

fix: dont crash on cutting with ghost paste #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
un000000 wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: dont crash on cutting with ghost paste #190

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions source/copybuffer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,13 @@ Position CopyBuffer::getPosition() const {
}

void CopyBuffer::clear() {
if (!tiles) {
return;
}

if (g_gui.secondary_map == tiles) {
g_gui.secondary_map = nullptr;
}
Comment on lines +54 to +56

@gemini-code-assist gemini-code-assist Bot May 23, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Instead of manually setting secondary_map to nullptr, you should call g_gui.EndPasting(). This will not only clear the secondary_map pointer but also reset the pasting flag to false. This fixes the "visual bug" mentioned in the PR description where the ghost paste remains active (but invisible) and allows for accidental pasting after the buffer has been cleared.

	if (g_gui.secondary_map == tiles) {
		g_gui.EndPasting();
	}

delete tiles;
tiles = nullptr;
}
Expand Down