Skip to content

fix: prevent grid truncation on ultrawide displays #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vllsystems wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: prevent grid truncation on ultrawide displays #196

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions source/gl_renderer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -823,13 +823,23 @@ void GLRenderer::flushCommands() {

while (i < verts.size()) {
size_t remaining = verts.size() - i;
size_t batchFree = STREAM_VBO_CAPACITY - batch.size();
// Number of vertices that still fit (rounded to a multiple of vertStep)
size_t canTake = (batchFree / vertStep) * vertStep;
size_t batchFreeVerts = STREAM_VBO_CAPACITY - batch.size();
size_t batchFreeIdx = STREAM_EBO_CAPACITY - indexBatch.size();
size_t canTakeStepsVerts = batchFreeVerts / vertStep;
size_t canTakeStepsIdx = batchFreeIdx / idxPerStep;
size_t canTake = std::min(canTakeStepsVerts, canTakeStepsIdx) * vertStep;

if (canTake == 0) {
flushBatch();
canTake = (STREAM_VBO_CAPACITY / vertStep) * vertStep;
batchFreeVerts = STREAM_VBO_CAPACITY - batch.size();
batchFreeIdx = STREAM_EBO_CAPACITY - indexBatch.size();
canTakeStepsVerts = batchFreeVerts / vertStep;
canTakeStepsIdx = batchFreeIdx / idxPerStep;
canTake = std::min(canTakeStepsVerts, canTakeStepsIdx) * vertStep;
Comment on lines +834 to +838

@gemini-code-assist gemini-code-assist Bot Jun 7, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Since flushBatch() clears the current batch and index batch, both batch.size() and indexBatch.size() are guaranteed to be 0 at this point. We can simplify this block by directly using STREAM_VBO_CAPACITY and STREAM_EBO_CAPACITY instead of performing redundant subtractions and size queries.

				canTakeStepsVerts = STREAM_VBO_CAPACITY / vertStep;
				canTakeStepsIdx = STREAM_EBO_CAPACITY / idxPerStep;
				canTake = std::min(canTakeStepsVerts, canTakeStepsIdx) * vertStep;

}

if (canTake == 0) {
break;
}

size_t take = std::min(remaining, canTake);
Expand Down
Loading