Skip to content

build: workflow add element-plus angular build add external - #220

Merged
rhlin merged 1 commit into
devfrom
build-optimize
Jul 21, 2026
Merged

build: workflow add element-plus angular build add external#220
rhlin merged 1 commit into
devfrom
build-optimize

Conversation

@gimmyhehe

@gimmyhehe gimmyhehe commented Jul 20, 2026

Copy link
Copy Markdown
Member

1、github action发包工作流添加element-plus
2、angular构建新增external,将core包和物料包从构建产物移除

Summary by CodeRabbit

  • New Features

    • Added support for publishing the Vue Element Plus materials package.
    • The new package can be built, versioned, and released through the standard publishing workflows.
  • Bug Fixes

    • Improved Angular renderer packaging by correctly handling shared core dependencies.
    • Updated Angular library builds to avoid bundling dependencies unnecessarily, helping produce cleaner and more reliable packages.

@coderabbitai

coderabbitai Bot commented Jul 20, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 57e531a7-bd15-494b-8b6c-19052d261698

📥 Commits

Reviewing files that changed from the base of the PR and between e0fee57 and fcd450d.

📒 Files selected for processing (5)
  • .github/workflows/publish-package.yml
  • .github/workflows/publish-packages.yml
  • packages/frameworks/angular/build-from-dist/vite.config.lib.ts
  • packages/frameworks/angular/projects/renderer/ng-package.json
  • packages/frameworks/angular/projects/renderer/package.json

Walkthrough

The PR adds Vue Element Plus materials to manual and optional publishing workflows. It also declares Angular renderer usage of the core package and configures the Angular library build to externalize that dependency.

Changes

Element Plus package publishing

Layer / File(s) Summary
Manual Element Plus publish configuration
.github/workflows/publish-package.yml
Adds the Vue Element Plus package to manual workflow options and resolves its package-specific build, synchronization, and publish paths.
Optional Element Plus publish pipeline
.github/workflows/publish-packages.yml
Updates optional package versioning, builds, dependency synchronization, and npm publishing to include the Vue Element Plus materials package.

Angular renderer packaging

Layer / File(s) Summary
Renderer core dependency contract
packages/frameworks/angular/projects/renderer/package.json, packages/frameworks/angular/projects/renderer/ng-package.json
Declares @opentiny/genui-sdk-core as a workspace dependency and permits it as a non-peer dependency.
Angular build externalization
packages/frameworks/angular/build-from-dist/vite.config.lib.ts
Uses renderer dependencies for Rollup externalization and removes @opentiny/genui-sdk-core from bundled packages.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
  participant PublishPackagesWorkflow
  participant VersionUpdater
  participant ElementPlusBuild
  participant WorkspaceSync
  participant Npm
  PublishPackagesWorkflow->>VersionUpdater: update Element Plus package version
  PublishPackagesWorkflow->>ElementPlusBuild: build optional package
  PublishPackagesWorkflow->>WorkspaceSync: synchronize workspace dependencies
  WorkspaceSync->>Npm: publish vue-element-plus package
Loading

Suggested reviewers: rhlin, lhuans

Poem

I’m a rabbit with packages tucked tight,
Element Plus hops into flight.
Angular keeps core outside,
While workflows publish far and wide.
Carrots, builds, and tags align—
The release burrow’s looking fine!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title is clearly related to the main changes: adding Element Plus workflow support and Angular build externalization.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch build-optimize

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

},
"dependencies": {
"tslib": "^2.3.0",
"@opentiny/genui-sdk-core": "workspace:*",

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

本身就有使用到,没有在这个包里面添加依赖声明,之前是把依赖包写到了最外层的package.json里面,然后直接内联了

@rhlin
rhlin merged commit 28a87f0 into dev Jul 21, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants