feat: update job information#107
Conversation
WalkthroughThis pull request updates Chinese localization strings and About page job data for recruitment: it changes department and team labels, updates recruitment positions from 2026 to 2027 (web/Java/AI), and adds a new C/C++ developer position with responsibilities and job items. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/home/src/i18n/zh.json`:
- Around line 187-190: The English i18n file is missing keys introduced in
zh.json (need_c, need_c_work1, need_c_work2, need_c_work3, banner_dept,
banner_issue1, introductory_team, need_web, need_java, need_ai) causing fallback
key rendering; add these same keys to packages/home/src/i18n/en.json with
appropriate English strings (translations or placeholders) matching the Chinese
entries so about/index.vue can display readable text, ensuring key names exactly
match those in zh.json.
In `@packages/home/src/views/about/index.vue`:
- Around line 258-267: The mobile view is rendering collapsible job items with
hardcoded indices (only 0..2) while new entries are added to the jobIntroduction
array, so update the mobile rendering to iterate over jobIntroduction instead of
specific indices: replace the three hardcoded collapse blocks with a v-for (or
equivalent loop) that uses the jobIntroduction array and each item’s properties
(name, directions, place, citys, posts, jobList, postSrc) to render collapses
dynamically so any new role (e.g., the item with name "3") appears on mobile.
- Line 835: The template contains a hardcoded Chinese string in the <p> element
(the about view index.vue snippet) which bypasses localization; replace that
literal with a $t(...) call (e.g. $t('about.wechatNote')) in the template and
add the corresponding i18n key "about.wechatNote" to your locale files (zh.json
and en.json) with the Chinese text for zh and an English translation for en (and
other locales as needed), ensuring the component imports/uses the existing i18n
instance so $t is available.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: f42db5bf-f10e-4c79-a2c6-8ff1fd234da1
📒 Files selected for processing (2)
packages/home/src/i18n/zh.jsonpackages/home/src/views/about/index.vue
* feat: update job information * feat: update job information
Summary by CodeRabbit