Skip to content

chore: remove useless runtime-version #3249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2025
Merged

Conversation

zzcr
Copy link
Member

@zzcr zzcr commented Apr 7, 2025

PR

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our Commit Message Guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Summary by CodeRabbit

  • Refactor
    • Streamlined build configurations by removing legacy version management, simplifying internal processes.
  • Tests
    • Eliminated outdated validation tests related to version information, reducing redundancy.

Copy link

coderabbitai bot commented Apr 7, 2025

Walkthrough

This pull request removes all references to the runtime version identifier from the codebase. In the build process, the assignment of process.env.RUNTIME_VERSION is eliminated and the corresponding configuration logic in the bundler settings is removed. Additionally, the utilities module has been refactored by deleting the exported version constant along with its related tests. No new public APIs have been introduced, and the overall behavior remains focused on eliminating version-based build metadata.

Changes

Files Change Summary
internals/cli/src/commands/build/build-runtime.ts
packages/renderless/tsup.config.ts
Removed runtime version handling: eliminated the assignment of process.env.RUNTIME_VERSION in the build command and removed the import of version along with the esbuildOptions function that defined it.
packages/utils/src/common/__tests__/index.test.ts
packages/utils/src/common/index.ts
packages/utils/src/index.ts
Removed the version constant export, its related import, and the test suite verifying the runtime version, thereby simplifying the module’s API.

Poem

I’m a rabbit with a hop so light,
Code shed its baggage, oh what a sight!
No runtime version to chase or chase,
Clean builds now set a simpler pace.
Nibble on bytes and bounce with delight,
For our repo feels airy and bright!

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

 WARN  GET http://10.0.0.28:4873/@antfu%2Feslint-config error (503). Will retry in 10 seconds. 2 retries left.
 WARN  GET http://10.0.0.28:4873/eslint-plugin-prettier error (503). Will retry in 10 seconds. 2 retries left.
 WARN  GET http://10.0.0.28:4873/prettier error (503). Will retry in 10 seconds. 2 retries left.
 WARN  GET http://10.0.0.28:4873/@types%2Feslint error (503). Will retry in 10 seconds. 2 retries left.
 WARN  GET http://10.0.0.28:4873/@volar-plugins%2Feslint error (503). Will retry in 10 seconds. 2 retries left.
 WARN  GET http://10.0.0.28:4873/eslint-config-prettier error (503). Will retry in 10 seconds. 2 retries left.
 WARN  GET http://10.0.0.28:4873/@volar-plugins%2Fprettier error (503). Will retry in 10 seconds. 2 retries left.
 WARN  GET http://10.0.0.28:4873/eslint error (503). Will retry in 10 seconds. 2 retries left.
 WARN  GET http://10.0.0.28:4873/@typescript-eslint%2Fparser error (503). Will retry in 10 seconds. 2 retries left.
 WARN  GET http://10.0.0.28:4873/fs-extra error (503). Will retry in 10 seconds. 2 retries left.
 WARN  GET http://10.0.0.28:4873/typescript error (503). Will retry in 10 seconds. 2 retries left.
 WARN  GET http://10.0.0.28:4873/@vue%2Ftsconfig error (503). Will retry in 10 seconds. 2 retries left.
 WARN  GET http://10.0.0.28:4873/vue error (503). Will retry in 10 seconds. 2 retries left.
 WARN  GET http://10.0.0.28:4873/@antfu%2Feslint-config error (503). Will retry in 1 minute. 1 retries left.
 WARN  GET http://10.0.0.28:4873/eslint-plugin-prettier error (503). Will retry in 1 minute. 1 retries left.
 WARN  GET http://10.0.0.28:4873/@volar-plugins%2Feslint error (503). Will retry in 1 minute. 1 retries left.
 WARN  GET http://10.0.0.28:4873/@types%2Feslint error (503). Will retry in 1 minute. 1 retries left.
 WARN  GET http://10.0.0.28:4873/prettier error (503). Will retry in 1 minute. 1 retries left.
 WARN  GET http://10.0.0.28:4873/eslint error (503). Will retry in 1 minute. 1 retries left.
 WARN  GET http://10.0.0.28:4873/eslint-config-prettier error (503). Will retry in 1 minute. 1 retries left.
 WARN  GET http://10.0.0.28:4873/@volar-plugins%2Fprettier error (503). Will retry in 1 minute. 1 retries left.
 WARN  GET http://10.0.0.28:4873/@typescript-eslint%2Fparser error (503). Will retry in 1 minute. 1 retries left.
 WARN  GET http://10.0.0.28:4873/typescript error (503). Will retry in 1 minute. 1 retries left.
 WARN  GET http://10.0.0.28:4873/vue error (503). Will retry in 1 minute. 1 retries left.
 WARN  GET http://10.0.0.28:4873/@vue%2Ftsconfig error (503). Will retry in 1 minute. 1 retries left.
 WARN  GET http://10.0.0.28:4873/fs-extra error (503). Will retry in 1 minute. 1 retries left.
 ERR_PNPM_FETCH_503  GET http://10.0.0.28:4873/@typescript-eslint%2Fparser: Service Unavailable - 503

This error happened while installing a direct dependency of /tmp/eslint


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 358d642 and 98a5d18.

📒 Files selected for processing (5)
  • internals/cli/src/commands/build/build-runtime.ts (0 hunks)
  • packages/renderless/tsup.config.ts (1 hunks)
  • packages/utils/src/common/__tests__/index.test.ts (1 hunks)
  • packages/utils/src/common/index.ts (0 hunks)
  • packages/utils/src/index.ts (1 hunks)
💤 Files with no reviewable changes (2)
  • packages/utils/src/common/index.ts
  • internals/cli/src/commands/build/build-runtime.ts
🔇 Additional comments (4)
packages/renderless/tsup.config.ts (1)

1-38: LGTM! Configuration is clean after removing runtime version.

The tsup configuration looks good after the removal of the runtime version implementation. The file now has a cleaner structure without the now-removed version import and esbuildOptions that previously defined process.env.RUNTIME_VERSION.

packages/utils/src/index.ts (1)

136-148: Exports successfully cleaned up after version removal.

The removal of the version export from the common module is consistent with the PR objective of removing the "useless runtime-version". This ensures that other parts of the codebase cannot import and use the removed version constant.

packages/utils/src/common/__tests__/index.test.ts (2)

1-14: Import list properly updated after version removal.

The import list has been correctly updated to remove the version import, which aligns with the removal of this constant from the common module.


16-130: Tests properly updated after removing version functionality.

All tests are passing after the removal of the version-related test suite. This is good practice - when removing functionality, also removing the corresponding tests to keep the codebase clean.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the chore label Apr 7, 2025
Copy link

github-actions bot commented Apr 7, 2025

[e2e-test-warn]
The component to be tested is missing.

The title of the Pull request should look like "fix(vue-renderless): [action-menu, alert] fix xxx bug".

Please make sure you've read our contributing guide

@kagol kagol merged commit 87c5286 into dev Apr 7, 2025
11 checks passed
@kagol kagol deleted the fix-runtime-version-0407 branch April 14, 2025 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants