Skip to content

fix(checkbox): [checkbox,select,base-select] change the checkbox icon and synchronously modify the checkbox style #3258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 7, 2025

Conversation

MomoPoppy
Copy link
Collaborator

@MomoPoppy MomoPoppy commented Apr 7, 2025

…modify the checkbox style

PR

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our Commit Message Guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Summary by CodeRabbit

  • Style
    • Enhanced checkbox and icon appearance with refined color transitions for active, hover, and disabled states.
    • Improved visual consistency across grid and option components for a more polished user interface.
    • Updated color settings to ensure disabled icons are clearer and better integrated into the overall theme.
    • Increased specificity in SVG path styling for checkboxes to ensure accurate color rendering based on state.

Copy link

coderabbitai bot commented Apr 7, 2025

Walkthrough

This pull request refines the CSS styling for checkbox and option icons by altering how the fill colors are applied. The updates modify the selectors to target specific SVG child paths for active, hover, disabled, unchecked, and checked states. Additionally, a CSS variable value is updated to change the visual appearance of disabled grid icons. No changes to exported or public declarations were made.

Changes

File(s) Summary of Changes
packages/theme/src/checkbox/index.less, packages/theme/src/grid/checkbox.less, packages/theme/src/option/index.less Refactored fill property assignments in SVGs: styling now targets specific child paths (first or second) for various checkbox and option states (active, hover, disabled, unchecked, checked) to enhance specificity.
packages/theme/src/grid/vars.less Updated the --tv-Grid-icon-inverse-disabled variable to use var(--tv-color-bg-inverse-disabled, #fff) instead of var(--tv-color-icon-inverse), altering the disabled state appearance.

Possibly related PRs

Suggested reviewers

  • zzcr

Poem

I'm just a bunny with hoppity cheer,
Tweaking those icons so they look clear.
Paths are refined with a stylish new code,
Making every checkbox a brighter abode.
Hop, hop—celebrate changes with a joyful, code-filled year!
🐇🎨

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

examples/sites/demos/pc/app/checkbox/basic-usage.spec.ts

Oops! Something went wrong! :(

ESLint: 8.57.1

ESLint couldn't find the plugin "eslint-plugin-vue".

(The package "eslint-plugin-vue" was not found when loaded as a Node module from the directory "".)

It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:

npm install eslint-plugin-vue@latest --save-dev

The plugin "eslint-plugin-vue" was referenced from the config file in ".eslintrc.js » @antfu/eslint-config » @antfu/eslint-config-vue".

If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 87a3f2e and 6446620.

📒 Files selected for processing (1)
  • examples/sites/demos/pc/app/checkbox/basic-usage.spec.ts (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: PR E2E Test (pnpm test:e2e3)
🔇 Additional comments (1)
examples/sites/demos/pc/app/checkbox/basic-usage.spec.ts (1)

8-8: Correctly updated test to match revised checkbox icon structure.

The test has been appropriately updated to check the first SVG path element (index 0) instead of a different element for the fill color. This change aligns with the broader modifications to the checkbox icon structure mentioned in the PR objectives.

✨ Finishing Touches
  • 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the bug Something isn't working label Apr 7, 2025
@MomoPoppy
Copy link
Collaborator Author

image
image
image

image
image

@MomoPoppy MomoPoppy changed the title fix(checkbox): [checkbox] change the checkbox icon and synchronously … fix(checkbox): [checkbox] change the checkbox icon and synchronously modify the checkbox style Apr 7, 2025
@MomoPoppy MomoPoppy changed the title fix(checkbox): [checkbox] change the checkbox icon and synchronously modify the checkbox style fix(checkbox): [checkbox,select,base-select,grid] change the checkbox icon and synchronously modify the checkbox style Apr 7, 2025
@MomoPoppy MomoPoppy changed the title fix(checkbox): [checkbox,select,base-select,grid] change the checkbox icon and synchronously modify the checkbox style fix(checkbox): [checkbox,select,base-select] change the checkbox icon and synchronously modify the checkbox style Apr 7, 2025
@zzcr zzcr merged commit 5220b07 into opentiny:dev Apr 7, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants