Skip to content

ci(workflow): updated the release workflow to allow for no component name input and added a step to build all components #3261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2025

Conversation

zzcr
Copy link
Member

@zzcr zzcr commented Apr 7, 2025

更新发布工作流,允许不输入组件名称并添加构建所有组件的步骤

PR

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our Commit Message Guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Summary by CodeRabbit

  • New Features

    • Streamlined the alpha release process to allow builds without specifying components—triggering an all-components build automatically when none are provided.
  • Chores

    • Removed an outdated dependency from a UI component package to optimize performance and simplify maintenance.

…put and added a step to build all components
Copy link

coderabbitai bot commented Apr 7, 2025

Walkthrough

The changes update a GitHub workflow and modify a package dependency. The workflow now accepts an empty components input by setting it as not required. This change introduces a conditional step that runs pnpm build:ui when no components are specified, while the existing build step runs only when components are provided. Additionally, a dependency entry for @opentiny/utils has been removed from the package JSON file for the year-table package.

Changes

Files Change Summary
.github/workflows/dispatch-ui-publish-alpha.yml - Changed components input from required to optional.
- Added conditional step "Run Build All Components" for empty input.
- Modified condition for "Run Build Components".
packages/vue/src/year-table/package.json - Removed dependency entry for @opentiny/utils from the dependencies section.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Workflow
    User->>Workflow: Dispatch trigger with input (components)
    alt Components input is empty
        Workflow->>Workflow: Execute "Run Build All Components" (pnpm build:ui)
    else Components input provided
        Workflow->>Workflow: Execute "Run Build Components"
    end
Loading

Suggested labels

ci

Poem

I'm a rabbit, hopping with delight,
Workflow steps now dance in the night.
Empty inputs or a chosen component,
Build commands leap with joy, so potent.
Digging through changes with a twitch of my nose,
In techno burrows, our clever progress grows! 🐇


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the chore label Apr 7, 2025
Copy link

github-actions bot commented Apr 7, 2025

[e2e-test-warn]
The component to be tested is missing.

The title of the Pull request should look like "fix(vue-renderless): [action-menu, alert] fix xxx bug".

Please make sure you've read our contributing guide

@zzcr zzcr changed the title chore: updated the release workflow to allow for no component name input and added a step to build all components ci(workflow): updated the release workflow to allow for no component name input and added a step to build all components Apr 7, 2025
@github-actions github-actions bot removed the chore label Apr 7, 2025
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
.github/workflows/dispatch-ui-publish-alpha.yml (2)

51-54: Conditional Build Step for Specified Components
The step "Run Build Components" now executes only when inputs.components is not empty using the condition if: inputs.components != ''. The logic is clear and meets the new requirement to build specified components. For added robustness, consider handling cases where the input may contain only whitespace.


55-57: Addition of Fallback Build Step for All Components
Introducing the "Run Build All Components" step with the condition if: inputs.components == '' is a neat approach for handling empty input scenarios. This ensures that when no component is specified, all components are built. As with the previous condition, you might want to consider trimming potential whitespace in the input for even greater resilience.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5220b07 and 17e82c0.

📒 Files selected for processing (2)
  • .github/workflows/dispatch-ui-publish-alpha.yml (2 hunks)
  • packages/vue/src/year-table/package.json (0 hunks)
💤 Files with no reviewable changes (1)
  • packages/vue/src/year-table/package.json
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: build
🔇 Additional comments (1)
.github/workflows/dispatch-ui-publish-alpha.yml (1)

11-11: Enhanced Input Flexibility for Workflow Dispatch
Changing the required attribute for the components input from true to false properly allows the workflow to trigger without a component name. This aligns with the objective to support cases where no specific component is provided.

@kagol kagol merged commit afd76e7 into dev Apr 7, 2025
21 of 24 checks passed
@kagol kagol deleted the feat-publish-alpha-0407 branch April 14, 2025 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants