-
Notifications
You must be signed in to change notification settings - Fork 299
ci(workflow): updated the release workflow to allow for no component name input and added a step to build all components #3261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…put and added a step to build all components
WalkthroughThe changes update a GitHub workflow and modify a package dependency. The workflow now accepts an empty Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Workflow
User->>Workflow: Dispatch trigger with input (components)
alt Components input is empty
Workflow->>Workflow: Execute "Run Build All Components" (pnpm build:ui)
else Components input provided
Workflow->>Workflow: Execute "Run Build Components"
end
Suggested labels
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
[e2e-test-warn] The title of the Pull request should look like "fix(vue-renderless): [action-menu, alert] fix xxx bug". Please make sure you've read our contributing guide |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
.github/workflows/dispatch-ui-publish-alpha.yml (2)
51-54
: Conditional Build Step for Specified Components
The step "Run Build Components" now executes only wheninputs.components
is not empty using the conditionif: inputs.components != ''
. The logic is clear and meets the new requirement to build specified components. For added robustness, consider handling cases where the input may contain only whitespace.
55-57
: Addition of Fallback Build Step for All Components
Introducing the "Run Build All Components" step with the conditionif: inputs.components == ''
is a neat approach for handling empty input scenarios. This ensures that when no component is specified, all components are built. As with the previous condition, you might want to consider trimming potential whitespace in the input for even greater resilience.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/workflows/dispatch-ui-publish-alpha.yml
(2 hunks)packages/vue/src/year-table/package.json
(0 hunks)
💤 Files with no reviewable changes (1)
- packages/vue/src/year-table/package.json
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: build
🔇 Additional comments (1)
.github/workflows/dispatch-ui-publish-alpha.yml (1)
11-11
: Enhanced Input Flexibility for Workflow Dispatch
Changing therequired
attribute for thecomponents
input fromtrue
tofalse
properly allows the workflow to trigger without a component name. This aligns with the objective to support cases where no specific component is provided.
更新发布工作流,允许不输入组件名称并添加构建所有组件的步骤
PR
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit
New Features
Chores