-
Notifications
You must be signed in to change notification settings - Fork 299
fix: fix build:runtime script #3263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe pull request updates the Changes
Sequence Diagram(s)sequenceDiagram
participant Runner as Build Runner
participant Icon as Icon Creator
participant Runtime as Runtime Builder
Runner->>Icon: Execute "pnpm create:icon-saas"
Icon-->>Runner: Icon component created
Runner->>Runtime: Execute "pnpm -C internals/cli build:runtime"
Runtime-->>Runner: Runtime built successfully
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
[e2e-test-warn] The title of the Pull request should look like "fix(vue-renderless): [action-menu, alert] fix xxx bug". Please make sure you've read our contributing guide |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
package.json (1)
56-56
: Enhanced build:runtime script with prerequisite icon SaaS creation.
The updated"build:runtime"
script now invokes"pnpm create:icon-saas"
before running"pnpm -C internals/cli build:runtime"
. This change is consistent with similar patterns used in other scripts (e.g.,"dev:saas"
,"site:saas"
) and ensures that the icon SaaS component is created as a prerequisite for the runtime build process.Please verify that:
- The
create:icon-saas
command does not introduce any unintended delays or side effects in environments where the icon SaaS component might have already been generated.- The sequential execution (
&&
) correctly aborts the runtime build if thecreate:icon-saas
fails.Overall, the change aligns with the PR objectives and helps in maintaining a proper build chain.
PR
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit