Skip to content

fix(base-select): [select,base-select] fix the highlight style of the selected item icon #3268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 8, 2025
Merged

fix(base-select): [select,base-select] fix the highlight style of the selected item icon #3268

merged 2 commits into from
Apr 8, 2025

Conversation

MomoPoppy
Copy link
Collaborator

@MomoPoppy MomoPoppy commented Apr 8, 2025 •
edited by coderabbitai bot
Loading

… selected item icon

PR

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our Commit Message Guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Summary by CodeRabbit

  • Style
    • Added extra vertical spacing in select component views to enhance layout clarity.
    • Adjusted the appearance of selected option icons and dropdown items for a more refined visual experience.
  • Chores
    • Updated version number for @opentiny/vue-theme package to 3.22.1.
    • Updated version number for @opentiny/vue-base-select package to 3.22.1.

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Apr 8, 2025 •
edited
Loading

Walkthrough

The pull request introduces minor adjustments to several Vue component templates and style sheets. It adds <br /> elements in multiple files to increase vertical spacing in the rendered output, and it makes subtle CSS modifications: one change involves the removal of a CSS rule affecting SVG icon coloring, while another adds an extra CSS class to a dropdown list element. No alterations were made to the exported or public entities.

Changes

Files Change Summary
examples/.../collapse-tags.vue
examples/.../collapse-tags-composition-api.vue		 Added three <br /> elements in the template before the "场景 3：click-expand 折叠" section.
examples/.../multiple-mix.vue
examples/.../multiple-mix-composition-api.vue		 Added two <br /> elements in the <tiny-form> component after the last <tiny-form-item> containing a <tiny-select> component.
packages/.../option/index.less Removed a CSS rule that set the fill color for the last child path within .selected .tiny-svg.
packages/.../base-select/src/pc.vue Modified a <li> element’s class attribute by adding tiny-option_all, adjusting its visual styling.
packages/.../theme/package.json
packages/.../base-select/package.json		 Updated version from 3.22.0 to 3.22.1 for both packages.

Suggested reviewers

  • zzcr

Poem

I’m a little rabbit, hopping through the code,
Adding breaks and tweaks along the winding road.
I nibble on <br /> spaces with a joyful, gentle bite,
And style tweaks make our UI ever so bright.
Hop on, dear coders, let’s celebrate this sight!
🐰✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 84166ae and e16788b.

📒 Files selected for processing (2)
  • packages/theme/package.json (1 hunks)
  • packages/vue/src/base-select/package.json (1 hunks)
✅ Files skipped from review due to trivial changes (2)
  • packages/theme/package.json
  • packages/vue/src/base-select/package.json
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: PR E2E Test (pnpm test:e2e3)
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the bug Something isn't working label Apr 8, 2025
@MomoPoppy
Copy link
Collaborator Author

image

@MomoPoppy
Copy link
Collaborator Author

image

@zzcr zzcr merged commit 0652fa0 into opentiny:release-3.22.0 Apr 8, 2025
8 of 10 checks passed
kagol pushed a commit that referenced this pull request Apr 30, 2025
@MomoPoppy @kagol
fix(base-select): [select,base-select] fix the highlight style of the…
7adfd3d 
… selected item icon (#3268)

* fix(base-select): [select,base-select] fix the highlight style of the selected item icon

* feat(base-select): [base-select] modify version number
zzcr added a commit that referenced this pull request Apr 30, 2025
@kagol @zzcr @MomoPoppy
Sync release-3.22.0 to dev (#3376)
7ca72cd 
* feat(release): add dist directory check for specific packages to optimize the release process (#3265)

* fix(base-select): [select,base-select] fix the highlight style of the selected item icon (#3268)

* fix(base-select): [select,base-select] fix the highlight style of the selected item icon

* feat(base-select): [base-select] modify version number

* chore: release v3.22.1 (#3275)

* chore: added the cdn address of Huicharts component runtime, and updated the version number of docs to 3.22.3

---------

Co-authored-by: ajaxzheng <[email protected]>
Co-authored-by: MomoPoppy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zzcr zzcr zzcr approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MomoPoppy @zzcr