-
Notifications
You must be signed in to change notification settings - Fork 299
feat(release): add vue3 version option to release:aurora command and update related logic #3280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…update related logic; modify the names of multiple packages to adapt to the new naming convention
WalkthroughThe changes update the release process for Aurora by modifying the functions in the release module. The function Changes
Sequence Diagram(s)sequenceDiagram
participant CLI as CLI (commander)
participant RA as releaseAurora
participant FAP as findAllpage
participant FS as File System
CLI->>RA: Execute release:aurora (--vue3version option)
RA->>FAP: Call findAllpage(packagesPath, vue3version)
alt vue3version provided
FAP->>FS: Replace '@aurora/vue' with '@aurora/vue3'
FAP->>RA: Append 'dist3/@aurora' to distLists
else vue3version not provided
FAP->>FS: Process normally
end
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
internals/cli/src/commands/release/releaseAurora.tsOops! Something went wrong! :( ESLint: 8.57.1 ESLint couldn't find the plugin "eslint-plugin-vue". (The package "eslint-plugin-vue" was not found when loaded as a Node module from the directory "".) It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:
The plugin "eslint-plugin-vue" was referenced from the config file in ".eslintrc.js » @antfu/eslint-config » @antfu/eslint-config-vue". If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team. internals/cli/src/index.tsOops! Something went wrong! :( ESLint: 8.57.1 ESLint couldn't find the plugin "eslint-plugin-vue". (The package "eslint-plugin-vue" was not found when loaded as a Node module from the directory "".) It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:
The plugin "eslint-plugin-vue" was referenced from the config file in ".eslintrc.js » @antfu/eslint-config » @antfu/eslint-config-vue". If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
🧰 Additional context used🧬 Code Graph Analysis (1)internals/cli/src/index.ts (1)
🔇 Additional comments (8)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
WalkthroughThis PR introduces a new option for the Changes
|
@@ -42,6 +42,10 @@ const findAllpage = (packagesPath) => { | |||
.replace(/@aurora\/fluent-editor/g, '@opentiny/fluent-editor') | |||
.replace(/@aurora\/huicharts/g, '@opentiny/huicharts') | |||
|
|||
if (vue3version) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure that the vue3version
parameter is correctly passed and utilized throughout the function to prevent any unexpected behavior when the Vue 3 version is specified.
[e2e-test-warn] The title of the Pull request should look like "fix(vue-renderless): [action-menu, alert] fix xxx bug". Please make sure you've read our contributing guide |
为 release:aurora 命令添加 vue3 版本选项,并更新相关逻辑
PR
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit
New Features
Chores
These updates improve the release process by offering enhanced version-specific functionality and eliminating outdated options.