-
Notifications
You must be signed in to change notification settings - Fork 299
fix: fix tsconfig paths not working #3362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe change updates the TypeScript configuration by adding an explicit "files" property set to an empty array in the tsconfig.json file. The existing project reference to tsconfig.vue3.json remains unchanged. No changes were made to any exported or public entities. Changes
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
WalkthroughThis pull request addresses an issue with TypeScript configuration paths not working by adding an empty Changes
|
@@ -1,3 +1,4 @@ | |||
{ | |||
"files": [], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding an empty files
array in tsconfig.json
can help resolve issues with path resolution by ensuring no files are included by default. However, make sure this change does not inadvertently exclude necessary files from the compilation process.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
tsconfig.json (1)
1-4
: Document the rationale for an empty files array
An empty"files": []
entry isn’t immediately obvious to future maintainers. Consider adding an inline comment or updating your repo’s CONTRIBUTING/README to explain that this forces a pure project-reference build (e.g. “// Intentionally empty to defer all file inclusion to tsconfig.vue3.json”).
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
tsconfig.json
(1 hunks)
🔇 Additional comments (1)
tsconfig.json (1)
2-2
: Double-check project reference behavior
By adding"files": []
, you’re explicitly preventing this tsconfig from including any root files and relying entirely on the referencedtsconfig.vue3.json
. This is correct for a pure project-reference setup, but can unintentionally exclude global declarations or path-mapped modules declared elsewhere. Please verify that all necessary compiler options and type definitions are indeed picked up via your reference.
PR
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit