ci(workflow): fix path matching rules to ensure only component directories are matched #3364
Conversation
WalkthroughThis update includes three main changes: a refinement of regular expression patterns in a GitHub Actions workflow to more precisely match component directories, a minor textual adjustment in the description of a Vue component example, and a modification to the title text in an HTML file for a mobile demo page. No changes were made to the logic, structure, or public interfaces of any components or scripts. Changes
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
examples/sites/demos/pc/app/alert/basic-usage.vueOops! Something went wrong! :( ESLint: 8.57.1 ESLint couldn't find the plugin "eslint-plugin-vue". (The package "eslint-plugin-vue" was not found when loaded as a Node module from the directory "".) It's likely that the plugin isn't installed correctly. Try reinstalling by running the following: The plugin "eslint-plugin-vue" was referenced from the config file in ".eslintrc.js » @antfu/eslint-config » @antfu/eslint-config-vue". If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
.github/workflows/test-e2e-pr.yml (1)
46-58: Remove trailing spaces to satisfy YAML lint
Several pattern lines have trailing spaces after the comma, which YAMLLint flags as errors. Trimming these spaces will resolve the lint issues.
Apply this diff:- pattern: /^packages\/renderless\/src\/([^/]+)\//, + pattern: /^packages\/renderless\/src\/([^/]+)\//, - pattern: /^packages\/vue\/src\/([^/]+)\//, + pattern: /^packages\/vue\/src\/([^/]+)\//, - pattern: /^examples\/sites\/demos\/pc\/app\/([^/]+)\//, + pattern: /^examples\/sites\/demos\/pc\/app\/([^/]+)\//,🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 46-46: trailing spaces
(trailing-spaces)
[error] 51-51: trailing spaces
(trailing-spaces)
[error] 52-52: trailing spaces
(trailing-spaces)
[error] 57-57: trailing spaces
(trailing-spaces)
[error] 58-58: trailing spaces
(trailing-spaces)
examples/sites/demos/pc/app/alert/basic-usage.vue (1)
9-9: Consistent spacing in description attribute
The description for the “simple” type was updated totype 为simple, removing the space between为andsimple. Other examples use a space (e.g.,type 为 success), so for readability and consistency considerdescription="type 为 simple".
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
.github/workflows/test-e2e-pr.yml(1 hunks)examples/sites/demos/pc/app/alert/basic-usage.vue(1 hunks)examples/sites/mobile.html(1 hunks)
🧰 Additional context used
🪛 YAMLlint (1.35.1)
.github/workflows/test-e2e-pr.yml
[error] 46-46: trailing spaces
(trailing-spaces)
[error] 51-51: trailing spaces
(trailing-spaces)
[error] 52-52: trailing spaces
(trailing-spaces)
[error] 57-57: trailing spaces
(trailing-spaces)
[error] 58-58: trailing spaces
(trailing-spaces)
🔇 Additional comments (5)
.github/workflows/test-e2e-pr.yml (4)
46-49: Restrict component matching to directories
The updated regex anchored at^packages/renderless/src/([^/]+)/with a trailing slash ensures you only detect component directories (and their subpaths), preventing files likepackage.jsonfrom being matched.🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 46-46: trailing spaces
(trailing-spaces)
52-55: Consistent directory-only regex for Vue components
Adding the trailing slash in the^packages/vue/src/([^/]+)/pattern brings it in line with the renderless rule, so only Vue component folders (not individual files) are captured.🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 52-52: trailing spaces
(trailing-spaces)
56-61: Example demo pattern – only match directories
The new rule^examples/sites/demos/pc/app/([^/]+)/with the slash now correctly targets demo component folders underapp/and skips files (e.g.,basic-usage.vuestill maps to thealertdirectory, but files likepackage.jsonwon’t trigger a match).🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 57-57: trailing spaces
(trailing-spaces)
[error] 58-58: trailing spaces
(trailing-spaces)
62-67: Theme components – enforce directory matching
By requiring the trailing slash in^packages/theme/src/([^/]+)/, you ensure theme component directories (and their nested files) are detected, while standalone files are excluded.examples/sites/mobile.html (1)
7-7: Verify the updated HTML document title
The title was changed to “TinyVueMobile 演示是”. Please confirm this text is grammatically correct in Chinese and consistent with other demo pages.
修正路径匹配规则以确保只匹配组件目录
PR
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit
Style
Chores