-
Notifications
You must be signed in to change notification settings - Fork 299
fix: [grid] Add a scroll bar at the bottom of the SaaS theme table to be placed inside the table, with only one border at the bottom #3365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughA new CSS rule was introduced to the grid component's table styling. Specifically, the last row within the table body ( Changes
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/theme-saas/src/grid/table.less (1)
274-289
: Eliminate redundant bottom-0 and prevent event interception
The::after
pseudo-element declares@apply bottom-0
twice; you can remove the duplicate and addpointer-events-none
so the line won’t block pointer events (e.g., scrolling).Apply this diff:
@@ 274,289 @@ tbody tr:last-child { @apply relative; &::after { @apply content-['']; @apply absolute; - @apply bottom-0; - @apply bottom-0; + @apply bottom-0; @apply left-0; @apply right-0; @apply h-px; @apply bg-color-bg-1; + @apply pointer-events-none; } }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
packages/theme-saas/src/grid/table.less
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: PR E2E Test (pnpm test:e2e3)
- GitHub Check: PR Unit Test
PR
改前:


改后:
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit