-
Notifications
You must be signed in to change notification settings - Fork 299
fix(input): Modify the color of the placeholder in the bottom right corner of the input component textarea type in the SaaS theme #3375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
WalkthroughThe change updates the styling of a specific element within the textarea component by modifying the text color for the count display. The color variable for the element with the class Changes
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/theme-saas/src/textarea/index.less (1)
42-44
: Enhance error-state visibility
In the.is-exceed
block, only the border is set toborder-color-error
. For stronger feedback, consider also applying@apply text-color-text-error;
on the__count
element so the number itself uses the error color.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
packages/theme-saas/src/textarea/index.less
(1 hunks)
🔇 Additional comments (1)
packages/theme-saas/src/textarea/index.less (1)
48-48
: Appropriate placeholder text color applied
Switching the count display to@apply text-color-text-placeholder
is correct—it aligns the bottom-right counter with the design’s placeholder text styling.
PR
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit