Skip to content

fix(input): Modify the color of the placeholder in the bottom right corner of the input component textarea type in the SaaS theme #3375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

chenxi-20
Copy link
Collaborator

@chenxi-20 chenxi-20 commented Apr 30, 2025

PR

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our Commit Message Guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Summary by CodeRabbit

  • Style
    • Updated the text color for the character count in the textarea component for improved visual consistency.

@chenxi-20 chenxi-20 added the bug Something isn't working label Apr 30, 2025
Copy link

coderabbitai bot commented Apr 30, 2025

Walkthrough

The change updates the styling of a specific element within the textarea component by modifying the text color for the count display. The color variable for the element with the class __count is switched from a secondary text color to a placeholder text color. No other styles or exported entities are affected.

Changes

File(s) Change Summary
packages/theme-saas/src/textarea/index.less Updated the text color for the __count element to use the placeholder color instead of the secondary text color.

Poem

A brush of color, swift and neat,
The count now dons a subtler suite.
Placeholder hues, so soft and light,
Make numbers gentle, never bright.
In lines of code, the change is small—
But rabbits notice, after all! 🐇✨


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
packages/theme-saas/src/textarea/index.less (1)

42-44: Enhance error-state visibility
In the .is-exceed block, only the border is set to border-color-error. For stronger feedback, consider also applying @apply text-color-text-error; on the __count element so the number itself uses the error color.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4209075 and 4cdabf3.

📒 Files selected for processing (1)
  • packages/theme-saas/src/textarea/index.less (1 hunks)
🔇 Additional comments (1)
packages/theme-saas/src/textarea/index.less (1)

48-48: Appropriate placeholder text color applied
Switching the count display to @apply text-color-text-placeholder is correct—it aligns the bottom-right counter with the design’s placeholder text styling.

@chenxi-20 chenxi-20 changed the title fix(input): Modify the color of the placeholder in the bottom right corner of the SaaS theme textarea fix: Modify the color of the placeholder in the bottom right corner of the input component textarea type in the SaaS theme Apr 30, 2025
@chenxi-20 chenxi-20 changed the title fix: Modify the color of the placeholder in the bottom right corner of the input component textarea type in the SaaS theme fix(input): Modify the color of the placeholder in the bottom right corner of the input component textarea type in the SaaS theme Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant