Sync release-3.22.0 to dev #3376
Conversation
WalkthroughThis set of changes primarily updates UI spacing and styling in Vue component demo files, adjusts package version numbers across several Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant PlaygroundApp
participant ImportMap
participant CDN
User->>PlaygroundApp: Load App.vue
PlaygroundApp->>ImportMap: createImportMap()
ImportMap->>CDN: Fetch @opentiny/vue-huicharts (new mapping)
CDN-->>ImportMap: Return module URL
ImportMap-->>PlaygroundApp: Provide import map with new entry
sequenceDiagram
participant ReleaseScript
participant FileSystem
loop For each package in distLists
ReleaseScript->>FileSystem: Check if package in needDistDirPackages
alt Package in needDistDirPackages
ReleaseScript->>FileSystem: Check for dist or dist3 directory
alt Directory exists
ReleaseScript->>ReleaseScript: Call findAllpage
else Directory missing
ReleaseScript-->>ReleaseScript: Skip findAllpage
end
else Not in needDistDirPackages
ReleaseScript->>ReleaseScript: Call findAllpage unconditionally
end
end
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
examples/sites/demos/pc/app/select/collapse-tags-composition-api.vueOops! Something went wrong! :( ESLint: 8.57.1 ESLint couldn't find the plugin "eslint-plugin-vue". (The package "eslint-plugin-vue" was not found when loaded as a Node module from the directory "".) It's likely that the plugin isn't installed correctly. Try reinstalling by running the following: The plugin "eslint-plugin-vue" was referenced from the config file in ".eslintrc.js » @antfu/eslint-config » @antfu/eslint-config-vue". If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team. examples/sites/demos/pc/app/select/collapse-tags.vueOops! Something went wrong! :( ESLint: 8.57.1 ESLint couldn't find the plugin "eslint-plugin-vue". (The package "eslint-plugin-vue" was not found when loaded as a Node module from the directory "".) It's likely that the plugin isn't installed correctly. Try reinstalling by running the following: The plugin "eslint-plugin-vue" was referenced from the config file in ".eslintrc.js » @antfu/eslint-config » @antfu/eslint-config-vue". If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team. examples/sites/demos/pc/app/select/multiple-mix-composition-api.vueOops! Something went wrong! :( ESLint: 8.57.1 ESLint couldn't find the plugin "eslint-plugin-vue". (The package "eslint-plugin-vue" was not found when loaded as a Node module from the directory "".) It's likely that the plugin isn't installed correctly. Try reinstalling by running the following: The plugin "eslint-plugin-vue" was referenced from the config file in ".eslintrc.js » @antfu/eslint-config » @antfu/eslint-config-vue". If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team.
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🔭 Outside diff range comments (1)
packages/vue/src/base-select/src/pc.vue (1)
458-466: 💡 Verification agent🧩 Analysis chain
Ensure styling support for the new class
You've added thetiny-option_allclass to the "select all"<li>element, which is great for targeting it separately. Please confirm that corresponding CSS rules are present (or add them) in the theme—otherwise this class won't have visual effect.Run this to verify whether the class is styled in any
.lessfile:
🏁 Script executed:
#!/bin/bash # Search for tiny-option_all in theme styles rg -n "\.tiny-option_all" packages/themeLength of output: 159
Add Dedicated Styles for
.tiny-option_all
The search shows.tiny-option_allis only mentioned in a negative selector inpackages/theme/src/option/index.less(line 103), with no positive styling rules targeting it. You’ll need to add CSS rules for the new class so the “select all” option renders correctly.• File to update:
- packages/theme/src/option/index.less (around line 103)
• Suggested addition (example):
/* Style for the “select all” option */ .tiny-option_all { padding: @tiny-option-padding; color: @tiny-option-color; .tiny-option__checkbox-wrap { margin-right: @tiny-option-checkbox-margin; } &.hover { background: @tiny-option-hover-bg; } &.selected { background: @tiny-option-selected-bg; color: @tiny-option-selected-color; } }Adjust variables to match your theme.
🧹 Nitpick comments (2)
internals/cli/src/commands/release/releaseAlpha.ts (1)
75-75: Consider alternatives to the delete operatorStatic analysis found an unrelated issue: Using the
deleteoperator on line 75 could impact performance.- delete PKGContent.dependencies + PKGContent.dependencies = undefinedexamples/sites/demos/pc/app/select/collapse-tags.vue (1)
19-21: Suggest using CSS for layout spacing instead of multiple<br />tags.Introducing three consecutive
<br />elements can lead to bloated markup and inconsistent spacing across different browsers. Consider applying a utility or scoped class (e.g.margin-toporpadding-top) to the container wrapping “场景 3” to achieve the same visual separation in a more semantic, maintainable way.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (13)
examples/sites/demos/pc/app/select/collapse-tags-composition-api.vue(1 hunks)examples/sites/demos/pc/app/select/collapse-tags.vue(1 hunks)examples/sites/demos/pc/app/select/multiple-mix-composition-api.vue(1 hunks)examples/sites/demos/pc/app/select/multiple-mix.vue(1 hunks)examples/sites/package.json(2 hunks)examples/sites/playground/App.vue(1 hunks)internals/cli/src/commands/release/releaseAlpha.ts(2 hunks)packages/theme/package.json(1 hunks)packages/theme/src/option/index.less(0 hunks)packages/vue-runtime/package.json(1 hunks)packages/vue/package.json(1 hunks)packages/vue/src/base-select/package.json(1 hunks)packages/vue/src/base-select/src/pc.vue(1 hunks)
💤 Files with no reviewable changes (1)
- packages/theme/src/option/index.less
🧰 Additional context used
🧬 Code Graph Analysis (1)
internals/cli/src/commands/release/releaseAlpha.ts (1)
internals/cli/src/commands/build/build-ui.ts (1)
pathFromPackages(18-18)
🪛 Biome (1.9.4)
internals/cli/src/commands/release/releaseAlpha.ts
[error] 80-81: Avoid the delete operator which can impact performance.
Unsafe fix: Use an undefined assignment instead.
(lint/performance/noDelete)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: PR E2E Test (pnpm test:e2e3)
🔇 Additional comments (10)
packages/vue/src/base-select/package.json (1)
4-4: Version bump aligns with core package
The@opentiny/vue-base-selectversion has been correctly incremented to3.22.1, staying in lockstep with the main Vue package. No further dependency or script changes are needed here.packages/theme/package.json (1)
4-4: Theme package version updated
The@opentiny/vue-themeversion has been bumped to3.22.1as part of the synchronized release. This is consistent with other core packages.packages/vue-runtime/package.json (1)
4-4: Runtime package version bump
The@opentiny/vue-runtimepackage version update to3.22.1is correct and matches the coordinated release across Vue-related packages.internals/cli/src/commands/release/releaseAlpha.ts (1)
80-104: Improved package processing with directory existence checkThis change adds a conditional check before processing packages, ensuring that
findAllpageis only called for packages like 'utils', 'vue-hooks', and 'vue-runtime' if they have either a 'dist' or 'dist3' directory. This is a good defensive programming approach that prevents processing packages with missing distribution directories.🧰 Tools
🪛 Biome (1.9.4)
[error] 80-81: Avoid the delete operator which can impact performance.
Unsafe fix: Use an undefined assignment instead.
(lint/performance/noDelete)
examples/sites/demos/pc/app/select/multiple-mix.vue (1)
13-14: Improved spacing in form layoutAdding line breaks after the multiple select field improves the visual separation between form elements, enhancing the demo's readability.
examples/sites/demos/pc/app/select/multiple-mix-composition-api.vue (1)
13-14: Improved spacing in form layoutAdding line breaks after the multiple select field improves the visual separation between form elements, enhancing the demo's readability. This change is consistent with the spacing adjustment made in the Options API version of this component.
examples/sites/demos/pc/app/select/collapse-tags-composition-api.vue (1)
19-21: Enhanced visual separation between select scenariosAdding three additional line breaks provides better visual separation between the second and third select scenarios, making the demo easier to read and the different examples more distinct from each other.
examples/sites/package.json (2)
4-4: Verify package version bump consistency.The
"version"field was updated to3.22.3. Please ensure this aligns with your Git tag, changelog and that all peer packages (e.g.@opentiny/vue,@opentiny/vue-theme, etc.) share the intended coordinated version.
61-61: Clarify narrowing ofvue-i18nversion range.Changing from a caret (
^9.1.10) to a tilde (~9.14.3) restricts upgrades to patch releases only. Was this intentional to pin to a known-good patch? If so, document the rationale in your PR description or release notes to help future maintainers.examples/sites/playground/App.vue (1)
81-81: Approve addition of the import-mapping for@opentiny/vue-huicharts.The new entry in
createImportMapfollows the same pattern used by other Tiny‐Vue packages. This will enable charting modules in the playground correctly.
| @@ -1,7 +1,7 @@ | |||
| { | |||
| "name": "@opentiny/vue", | |||
| "private": true, | |||
| "version": "3.22.0", | |||
| "version": "3.22.1", | |||
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Confirm version bump to 3.22.1
The package version has been updated from 3.22.0 to 3.22.1, matching sibling packages. Ensure that your changelog or release notes include an entry for this new version.
Please run the following script to verify the changelog entry exists:
🏁 Script executed:
#!/bin/bash
# Ensure CHANGELOG entry exists for 3.22.1
fd CHANGELOG.md --exec grep -n "##\s*3\.22\.1"Length of output: 48
🏁 Script executed:
#!/usr/bin/env bash
# Locate any changelog files in the repository
fd -I -t f '*CHANGELOG*.md'
# Search for version 3.22.1 entry in all changelog files
fd -I -t f '*CHANGELOG*.md' --exec grep -n -E '##\s*3\.22\.1' {} \;Length of output: 690
🏁 Script executed:
#!/usr/bin/env bash
# Find any changelog markdown files
fd --glob '*CHANGELOG*.md' -t f
# Search for version 3.22.1 entries in each changelog file
for file in $(fd --glob '*CHANGELOG*.md' -t f); do
echo "Checking $file:"
grep -nE '##\s*3\.22\.1' "$file" || echo " → No entry for 3.22.1 in $file"
doneLength of output: 734
Add missing CHANGELOG entry for v3.22.1
No “## 3.22.1” entry was found in any changelog. Please add a release note for this patch in the appropriate CHANGELOG.md:
• CHANGELOG.md (root)
(If you maintain a per-package changelog for vue, add it under packages/vue/CHANGELOG.md)
Example snippet to include:
## 3.22.1 – YYYY-MM-DD
- Describe the bugfixes, improvements or dependency updates included in this release.Committable suggestion skipped: line range outside the PR's diff.
PR
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit
Style
Chores
Refactor