fix: fixed the problem that fullscreen style would pollute the global

[zzcr]

fix: 修复fullscreen样式会污染全局的问题

PR

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our Commit Message Guidelines
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

• Yes
• No

Other information

Summary by CodeRabbit

• Style
  • Improved consistency and scoping of editor styles by refining selector nesting and adjusting padding values.
  • Removed redundant and misplaced style rules for better maintainability.
  • No visual changes to features or functionality are expected for end-users.

[coderabbitai]

Walkthrough

The changes update LESS stylesheet files for two theme packages by correcting selector scoping and removing redundant or misplaced braces. In both files, standalone .fullscreen selectors are replaced with nested &.fullscreen selectors to ensure styles are applied contextually. Several unnecessary or duplicate padding properties are removed, and selector blocks are cleaned up by eliminating unmatched braces and redundant lines. No actual style property values are changed, and no exported or public entities are affected.

Changes

File(s)	Change Summary
packages/theme-saas/src/fluent-editor/index.less	Removed unmatched closing braces, replaced standalone .fullscreen selector with nested &.fullscreen. No style values changed.
packages/theme/src/fluent-editor/index.less	Adjusted padding properties for toolbar and picker elements, removed redundant lines and braces, converted .fullscreen to nested &.fullscreen. No style values changed.

Poem

In the garden of styles, a rabbit did hop,
Tidying up selectors, making braces drop.
Fullscreen now nested, neat as can be,
Padding trimmed gently, light as a leaf on a tree.
With every hop and every sweep,
The code grows clearer—oh, what a leap!
🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7ca72cd and e4f5512.

📒 Files selected for processing (2)

• packages/theme-saas/src/fluent-editor/index.less (1 hunks)
• packages/theme/src/fluent-editor/index.less (5 hunks)

🔇 Additional comments (7)

packages/theme-saas/src/fluent-editor/index.less (1)

272-280: Correctly scope fullscreen styles within the editor wrapper.

Moving the &.fullscreen block under the parent selector ensures fullscreen styles no longer leak globally, directly addressing the style-pollution issue described in the PR.

packages/theme/src/fluent-editor/index.less (6)

15-15: Validate toolbar padding adjustment.

The change to padding: 8px 16px 4px; removes an explicit left padding value. Please verify this does not introduce misalignment in the toolbar across different screen sizes or localized layouts.

---

180-180: Approve consistent horizontal padding shorthand.

Using the 3-value shorthand (padding: 4px 6px 0;) cleans up the rule while maintaining equal left/right spacing.

---

221-221: Whitespace cleanup before fullscreen modifier.

Adding a blank line improves visual separation between the hover styles and the subsequent .ql-fullscreen block.

---

250-250: Verify editor content padding update.

Changing the editor’s bottom padding to 86px affects content spacing. Please confirm this retains the intended scroll area and doesn’t cause overflow in embedded contexts.

---

254-254: Improve readability between style blocks.

The inserted blank line after the .ql-editor block helps separate it from the tooltip rules, enhancing maintainability.

---

319-326: Scope .fullscreen styles to avoid global pollution.

Nesting the &.fullscreen selector under the editor wrapper correctly contains fullscreen styles in this theme, mirroring the fix in the SaaS variant.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[petercat-assistant]

Walkthrough

This pull request addresses the issue where the fullscreen style was affecting global styles. The changes ensure that the fullscreen styles are scoped locally to prevent global pollution.

Changes

Files Changed	Summary
packages/theme-saas/src/fluent-editor/index.less	Modified .fullscreen styles to be scoped locally using &.fullscreen.
packages/theme/src/fluent-editor/index.less	Adjusted padding and scoped .fullscreen styles locally using &.fullscreen.

[petercat-assistant]

Ensure that the &.fullscreen selector is correctly scoped to avoid any unintended global style application.

[petercat-assistant]

Ensure that the &.fullscreen selector is correctly scoped to avoid any unintended global style application.