Skip to content

fix: modify the SaaS theme style of the dialog-box window #3380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix: modify the SaaS theme style of the dialog-box window #3380

wants to merge 1 commit into from

Conversation

James-9696
Copy link
Collaborator

@James-9696 James-9696 commented Apr 30, 2025 •
edited by coderabbitai bot
Loading

PR

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our Commit Message Guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Summary by CodeRabbit

  • Style
    • Updated the border colors of the dialog box header and footer for improved visual consistency.

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Apr 30, 2025 •
edited
Loading

Walkthrough

This change updates the border color styling for the header and footer of the dialog box component. The CSS class names responsible for the header's bottom border and the footer's top border were modified in both the LESS stylesheet and the Vue component. No logic, structure, or exported entities were altered; the update is limited to the visual appearance of the dialog box borders.

Changes

File(s) Change Summary
packages/theme-saas/src/dialog-box/index.less Updated the header's bottom border and footer's top border color class names for the dialog box.
packages/vue/src/dialog-box/src/mobile-first.vue Changed CSS class names for header and footer border colors in the dialog box component.

Poem

A dash of color, a border anew,
Dialogs now shine with a fresher hue.
No logic was touched, no code did we bend,
Just a gentle style tweak from end to end.
The rabbit hops by, with a painter’s delight—
Making sure your dialogs look just right!
🐇🎨✨

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

packages/vue/src/dialog-box/src/mobile-first.vue

Oops! Something went wrong! :(

ESLint: 8.57.1

ESLint couldn't find the plugin "eslint-plugin-vue".

(The package "eslint-plugin-vue" was not found when loaded as a Node module from the directory "".)

It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:

npm install eslint-plugin-vue@latest --save-dev

The plugin "eslint-plugin-vue" was referenced from the config file in ".eslintrc.js » @antfu/eslint-config » @antfu/eslint-config-vue".

If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7ca72cd and 1a39392.

📒 Files selected for processing (2)
  • packages/theme-saas/src/dialog-box/index.less (2 hunks)
  • packages/vue/src/dialog-box/src/mobile-first.vue (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: PR E2E Test (pnpm test:e2e3)
🔇 Additional comments (4)
packages/theme-saas/src/dialog-box/index.less (2)

59-67: Ensure theme token availability for header border color
The header bottom border now uses the fill-1 design token (border-color-fill-1). Please verify that this token is defined and exported in your SaaS theme variables (e.g., in custom.less) and that it renders the intended color.

128-134: Approve footer border update
The footer top border has been updated to the same fill-1 token, which matches the header change. The combination of border-t and border-color-fill-1 is correct to scope the color to only the top edge.

packages/vue/src/dialog-box/src/mobile-first.vue (2)

33-36: Verify header styling in component matches theme
You’ve updated the inline header classes to border-b border-color-fill-1 to reflect the SaaS theme change. Please preview the dialog in both desktop and mobile breakpoints to ensure the border renders correctly and doesn’t introduce regressions in other themes (light/dark).

91-93: Validate footer component border and spacing
The footer’s border-t border-color-fill-1 matches the LESS update. Double-check with different slot contents that this change doesn’t disrupt existing button/toolbar spacing rules.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the bug Something isn't working label Apr 30, 2025
@petercat-assistant PeterCat-assistant
Copy link

Walkthrough

This PR modifies the SaaS theme style of the dialog-box window by updating the border color classes in both LESS and Vue files. The changes ensure consistency in the theme's appearance.

Changes

Files Summary
packages/theme-saas/src/dialog-box/index.less Updated border color classes from border-b-color-bg-3 and border-t-color-bg-3 to border-color-fill-1.
packages/vue/src/dialog-box/src/mobile-first.vue Changed border color classes in the header and footer sections to border-color-fill-1.

petercat-assistant[bot]
petercat-assistant bot reviewed Apr 30, 2025
View reviewed changes
packages/theme-saas/src/dialog-box/index.less
@@ -64,7 +64,7 @@
@apply flex;
@apply justify-between;
@apply items-center;
@apply border-b border-b-color-bg-3;
@apply border-b border-color-fill-1;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that the new border color border-color-fill-1 is defined and applied correctly across different themes to avoid any visual inconsistencies.

petercat-assistant[bot]
petercat-assistant bot reviewed Apr 30, 2025
View reviewed changes
packages/vue/src/dialog-box/src/mobile-first.vue
@@ -31,7 +31,7 @@
<div
v-if="showHeader"
data-tag="tiny-dialog-box__header"
class="px-6 py-4 leading-5.5 bg-color-bg-1 flex justify-between items-center border-b border-b-color-bg-3"
class="px-6 py-4 leading-5.5 bg-color-bg-1 flex justify-between items-center border-b border-color-fill-1"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verify that border-color-fill-1 is consistent with the design specifications and does not introduce any unintended visual changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petercat-assistant petercat-assistant[bot] petercat-assistant[bot] left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@James-9696