-
Notifications
You must be signed in to change notification settings - Fork 299
fix(select): remove the binding of dropStyle to the scrollbar #3381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
WalkthroughThis change updates the dropdown list rendering in a Vue component by removing the binding of the Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
WalkthroughThis pull request removes the binding of Changes
|
@@ -475,7 +475,6 @@ | |||
tag="ul" | |||
:wrap-class="['tiny-select-dropdown__wrap']" | |||
:view-class="['tiny-select-dropdown__list']" | |||
:wrapStyle="dropStyle" | |||
@mousedown.stop |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The removal of :wrapStyle="dropStyle"
means that any dynamic styling previously applied to the select-dropdown__wrap
will no longer be in effect. Ensure that this change does not affect any required styling or functionality of the dropdown component.
PR
PR Checklist
回退dropStyle的透传给 select-dropdown__wrap的做法。
将select的 dropStyle透传给scrollbar后,引起2个问题
1、 双滚动条的风险, 当dropStyle配置的宽度小于select的宽度时, scrollbar 和它的子列表会有2个滚动条。
2、select的弹出层flip时, 会向下几个像素, 造成select跟popper重叠了。
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit