Skip to content

fix(select): remove the binding of dropStyle to the scrollbar #3381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

shenjunjian
Copy link
Collaborator

@shenjunjian shenjunjian commented Apr 30, 2025

PR

PR Checklist

回退dropStyle的透传给 select-dropdown__wrap的做法。

将select的 dropStyle透传给scrollbar后,引起2个问题
1、 双滚动条的风险, 当dropStyle配置的宽度小于select的宽度时, scrollbar 和它的子列表会有2个滚动条。
2、select的弹出层flip时, 会向下几个像素, 造成select跟popper重叠了。

  • The commit message follows our Commit Message Guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Summary by CodeRabbit

  • Refactor
    • Removed inline style application from the dropdown list’s scrollbar wrapper to streamline appearance.

Copy link

coderabbitai bot commented Apr 30, 2025

Walkthrough

This change updates the dropdown list rendering in a Vue component by removing the binding of the dropStyle property from the wrapStyle attribute on the <tiny-scrollbar> element. As a result, the scrollbar wrapper will no longer receive inline styles from dropStyle. No other logic, event handling, or control flow is modified in this update.

Changes

File(s) Change Summary
packages/vue/src/select/src/pc.vue Removed the dropStyle property binding from the wrapStyle attribute on <tiny-scrollbar>.

Poem

A scroll without a style, so neat,
The dropdown floats with less concrete.
No wrapper dress, no inline flair,
Just simple lists with open air.
The rabbit hops with code so light,
Less clutter now, and all feels right!
🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7ca72cd and 4a706a1.

📒 Files selected for processing (1)
  • packages/vue/src/select/src/pc.vue (0 hunks)
💤 Files with no reviewable changes (1)
  • packages/vue/src/select/src/pc.vue
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: PR E2E Test (pnpm test:e2e3)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the bug Something isn't working label Apr 30, 2025
Copy link

Walkthrough

This pull request removes the binding of dropStyle to the select-dropdown__wrap in the select component. This change reverts the previous approach of passing dropStyle through to the select-dropdown__wrap.

Changes

File Summary
packages/vue/src/select/src/pc.vue Removed the :wrapStyle attribute that was binding dropStyle to the select-dropdown__wrap.

@@ -475,7 +475,6 @@
tag="ul"
:wrap-class="['tiny-select-dropdown__wrap']"
:view-class="['tiny-select-dropdown__list']"
:wrapStyle="dropStyle"
@mousedown.stop

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The removal of :wrapStyle="dropStyle" means that any dynamic styling previously applied to the select-dropdown__wrap will no longer be in effect. Ensure that this change does not affect any required styling or functionality of the dropdown component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant