Resource lifecycle.destroy support for OpenTofu 1.12 #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ilia Gogotchuri <[email protected]>
Gogotchuri
changed the title
yottta
approved these changes
Dec 12, 2025
Contributor
yottta
left a comment
yottta
left a comment
There was a problem hiding this comment.
Other than one comment loosely related with the code here, looks good.
| Constraint: schema.LiteralType{Type: cty.Bool}, | ||
| DefaultValue: schema.DefaultValue{Value: cty.True}, | ||
| IsOptional: true, | ||
| Description: lang.Markdown(fmt.Sprintf("Setting `destroy` to `false` changes the OpenTofu's default behavior when destroying or replacing the resource. \n OpenTofu will 'forget' the resource instance, removing it from the state without destroying the actual infrastructure object. \n Read more about the `destroy` lifecycle argument in the [documentation](https://opentofu.org/docs/language/resources/behavior/#lifecycle-customizations).")), |
Contributor
There was a problem hiding this comment.
Maybe I am looking in the wrong place, but shouldn't the link here actually mention something about the destroy argument? 🤔 I cannot see it mentioned.
Member
Author
There was a problem hiding this comment.
I don't think I have added a separate ID to that section for the destroy attribute.
This points to the general section of the resource lifecycle customizations where the main description of the destroy attribute will be located (as a third option as I remember, but still)
If you think that would be significantly better, I can add ID in the documentation and make this reference directly tied to the destroy attribute.
diofeher
reviewed
Dec 12, 2025
| Constraint: schema.LiteralType{Type: cty.Bool}, | ||
| DefaultValue: schema.DefaultValue{Value: cty.True}, | ||
| IsOptional: true, | ||
| Description: lang.Markdown(fmt.Sprintf("Setting `destroy` to `false` changes the OpenTofu's default behavior when destroying or replacing the resource. \n OpenTofu will 'forget' the resource instance, removing it from the state without destroying the actual infrastructure object. \n Read more about the `destroy` lifecycle argument in the [documentation](https://opentofu.org/docs/language/resources/behavior/#lifecycle-customizations).")), |
Member
There was a problem hiding this comment.
Suggested change
| Description: lang.Markdown(fmt.Sprintf("Setting `destroy` to `false` changes the OpenTofu's default behavior when destroying or replacing the resource. \n OpenTofu will 'forget' the resource instance, removing it from the state without destroying the actual infrastructure object. \n Read more about the `destroy` lifecycle argument in the [documentation](https://opentofu.org/docs/language/resources/behavior/#lifecycle-customizations).")), | |
| Description: lang.Markdown("Setting `destroy` to `false` changes the OpenTofu's default behavior when destroying or replacing the resource. \n OpenTofu will 'forget' the resource instance, removing it from the state without destroying the actual infrastructure object. \n Read more about the `destroy` lifecycle argument in the [documentation](https://opentofu.org/docs/language/resources/behavior/#lifecycle-customizations)."), |
diofeher
approved these changes
Dec 12, 2025
Member
diofeher
left a comment
diofeher
left a comment
There was a problem hiding this comment.
Other than the small nit, looks good to me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for the new lifecycle.destroy atrribute in resource for the next OpenTofu release