Skip to content

docs: add zed extension installation to USAGE.md and installation.md - #96

Merged
Gogotchuri merged 3 commits into
opentofu:mainfrom
tzabbi:main
Jul 14, 2025
Merged

docs: add zed extension installation to USAGE.md and installation.md#96
Gogotchuri merged 3 commits into
opentofu:mainfrom
tzabbi:main

Conversation

@tzabbi

@tzabbi tzabbi commented Jul 7, 2025

Copy link
Copy Markdown
Contributor

Resolves #98

Checklist

  • I have read the contribution guide.
  • I have not used an AI coding assistant to create this PR.
  • I have written all code in this PR myself OR I have marked all code I have not written myself (including modified code, e.g. copied from other places and then modified) with a comment indicating where it came from.
  • I (and other contributors to this PR) have not looked at the Terraform source code while implementing this PR.

Go checklist

  • I have run golangci-lint on my change and receive no errors relevant to my code.
  • I have run existing tests to ensure my code doesn't break anything.
  • I have added tests for all relevant use cases of my code, and those tests are passing.
  • I have only exported functions, variables and structs that should be used from other packages.
  • I have added meaningful comments to all exported functions, variables, and structs.

@tzabbi
tzabbi requested a review from a team as a code owner July 7, 2025 09:47

@Gogotchuri Gogotchuri left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your time. We love to see the community getting involved.
I have a few comments about the PR that need to be addressed before we can merge it.

Firstly, please only include changes that are relevant to the issue this PR solves. You should remove the reformatting changes. This will make reviewing much easier.

Also, please always link the issue you are addressing. In case such an issue doesn't exist, please create it first. In this case, I would mention it as "Relates to #48". I've gone ahead and made a sub-issue for Zed (#98) under #48 and edited your PR.

Comment thread docs/USAGE.md Outdated
@tzabbi

tzabbi commented Jul 13, 2025

Copy link
Copy Markdown
Contributor Author

Thank you for your time. We love to see the community getting involved. I have a few comments about the PR that need to be addressed before we can merge it.

Firstly, please only include changes that are relevant to the issue this PR solves. You should remove the reformatting changes. This will make reviewing much easier.

Also, please always link the issue you are addressing. In case such an issue doesn't exist, please create it first. In this case, I would mention it as "Relates to #48". I've gone ahead and made a sub-issue for Zed (#98) under #48 and edited your PR.

Thank you for your help and your review! Hope I solved all issues.

@Gogotchuri Gogotchuri left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!
Thank you for the changes.

@diofeher diofeher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thanks!

There's a small typo and then we can merge it :)

Comment thread docs/USAGE.md Outdated
Signed-off-by: Ilia Gogotchuri <ilia.gogotchuri0@gmail.com>
@diofeher
diofeher self-requested a review July 14, 2025 12:47
@Gogotchuri
Gogotchuri merged commit b06bfd9 into opentofu:main Jul 14, 2025
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Zed usage documentation

4 participants