Skip to content

Add ContainerRequestContext to decorateResponse arguments. #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add ContainerRequestContext to decorateResponse arguments. #136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ...racing-jaxrs2/src/main/java/io/opentracing/contrib/jaxrs2/server/ServerSpanDecorator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,11 @@ public interface ServerSpanDecorator {
/**
* Decorate spans by outgoing object.
*
* @param requestContext
* @param responseContext
* @param span
*/
void decorateResponse(ContainerResponseContext responseContext, Span span);
void decorateResponse(ContainerRequestContext requestContext, ContainerResponseContext responseContext, Span span);

/**
* Adds standard tags: {@link io.opentracing.tag.Tags#SPAN_KIND},
Expand All @@ -45,7 +46,7 @@ public void decorateRequest(ContainerRequestContext requestContext, Span span) {
}

@Override
public void decorateResponse(ContainerResponseContext responseContext, Span span) {
public void decorateResponse(ContainerRequestContext requestContext, ContainerResponseContext responseContext, Span span) {
Tags.HTTP_STATUS.set(span, responseContext.getStatus());
}
};
Expand Down
2 changes: 1 addition & 1 deletion ...racing-jaxrs2/src/main/java/io/opentracing/contrib/jaxrs2/server/ServerTracingFilter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ public void filter(ContainerRequestContext requestContext,

if (spanDecorators != null) {
for (ServerSpanDecorator decorator: spanDecorators) {
decorator.decorateResponse(responseContext, spanWrapper.get());
decorator.decorateResponse(requestContext, responseContext, spanWrapper.get());
}
}
}
Expand Down