Update yaml-cpp

[lucacome]

Summary by CodeRabbit

• Chores
  • Updated the Jaeger C++ client build to pin the YAML C++ dependency to a specific commit and revised the dependency retrieval and build sequence to ensure a reproducible build.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

Changed the Dockerfile's jaeger-cpp-client build stage to fetch and check out a specific yaml-cpp commit hash instead of cloning by tag; the repository initialization and fetch/checkout steps were added and the yaml-cpp build sequence reordered accordingly.

Changes

Cohort / File(s)	Summary
Dockerfile: jaeger-cpp-client build Dockerfile	YAML_CPP_VERSION default changed from 0.8.0 to commit 89ff142b991af432b5d7a7cee55282f082a7e629. Replaced direct git clone -b $YAML_CPP_VERSION with repository init, git fetch of the specific commit and git checkout FETCH_HEAD. Adjusted source retrieval ordering before creating .build and running cmake/make.

Sequence Diagram(s)

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'Update yaml-cpp' directly corresponds to the main change: updating yaml-cpp from version 0.8.0 to a specific commit hash with a revised build approach.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch deps/yaml-cpp

---

🧹 Recent nitpick comments

Dockerfile (1)

142-142: Pinning to a specific commit hash is a good practice for reproducible builds. The commit 89ff142b991af432b5d7a7cee55282f082a7e629 exists and is a post-0.8.0 maintenance commit from October 24, 2025 that adds IWYU export pragmas.

Consider adding a comment noting the version and date for future maintainability:

ARG YAML_CPP_VERSION=89ff142b991af432b5d7a7cee55282f082a7e629  # yaml-cpp post-0.8.0, 2025-10-24

---

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fda2b19 and 0c29f6d.

📒 Files selected for processing (1)

• Dockerfile

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)

• GitHub Check: Build Docker Image
• GitHub Check: System Testing
• GitHub Check: Build Docker Image (debian)
• GitHub Check: Build Docker Image (alpine)
• GitHub Check: Analyze (go)

🔇 Additional comments (1)

Dockerfile (1)

146-157: LGTM! The git fetch/checkout workflow is now correct.

This properly addresses the previous review concerns:

• git checkout FETCH_HEAD now runs in the yaml-cpp repository root (before creating .build)
• git fetch --depth 1 <url> <commit> correctly fetches only the specific commit, avoiding the shallow clone issue where the commit might not exist on master HEAD

The build sequence is now: init → fetch specific commit → checkout → create build dir → cmake.

_{✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@Dockerfile`:
- Around line 146-148: The RUN block runs git checkout after cd .build (a
non-repo) and uses --depth 1 which may not contain YAML_CPP_VERSION commit;
update the sequence so you clone into yaml-cpp, cd into yaml-cpp, fetch the
specific commit (e.g. use git fetch --depth=1 origin $YAML_CPP_VERSION or fetch
that commit) and then git checkout $YAML_CPP_VERSION before creating/entering
.build; ensure git checkout operates in the repository root (yaml-cpp) and that
the clone/fetch strategy retrieves the exact commit rather than relying on a
shallow master HEAD.

📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1c82937 and fda2b19.

📒 Files selected for processing (1)

• Dockerfile

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)

• GitHub Check: System Testing
• GitHub Check: Build Docker Image
• GitHub Check: Build Docker Image (alpine)
• GitHub Check: Build Docker Image (debian)
• GitHub Check: Analyze (go)

_{✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.}