Skip to content

Build modules for NGINX 1.29.0 and 1.29.1#911

Merged
lucacome merged 3 commits intomasterfrom
feat/modules
Aug 16, 2025
Merged

Build modules for NGINX 1.29.0 and 1.29.1#911
lucacome merged 3 commits intomasterfrom
feat/modules

Conversation

@lucacome
Copy link
Copy Markdown
Member

@lucacome lucacome commented Aug 14, 2025

Added new versions of NGINX

Summary by CodeRabbit

  • Chores
    • Expanded build coverage to include Nginx 1.29.0 and 1.29.1; binaries are now built and published for these versions.
    • Adjusted CI to not stop the entire build matrix on a single failure (builds continue for other configurations).
    • No changes to runtime behavior or supported versions; installation and compatibility for end users are preserved.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Aug 14, 2025

Walkthrough

Adds fail-fast: false to the Build Binaries job strategy and extends its nginx_version matrix with versions 1.29.0 and 1.29.1 in .github/workflows/ci.yml. No other workflow logic or steps changed.

Changes

Cohort / File(s) Summary of Changes
CI workflow updates
.github/workflows/ci.yml
Set strategy.fail-fast: false for the Build Binaries job and added nginx_version entries 1.29.0 and 1.29.1 to the job matrix; no other changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~7 minutes

Possibly related PRs

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 8d780d4 and d4b0509.

📒 Files selected for processing (1)
  • .github/workflows/ci.yml (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • .github/workflows/ci.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
  • GitHub Check: Build Docker Image (alpine)
  • GitHub Check: Build Docker Image (debian)
  • GitHub Check: Build Binaries (1.27.2)
  • GitHub Check: Build Binaries (1.27.3)
  • GitHub Check: Build Binaries (1.26.0)
  • GitHub Check: Build Docker Image
  • GitHub Check: System Testing
  • GitHub Check: Analyze (go)
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/modules

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
.github/workflows/ci.yml (1)

64-65: Optional: disable matrix fail-fast so one new version failure doesn’t cancel others.

If a single 1.29.x build fails due to upstream changes, GitHub Actions may cancel the rest of the matrix (default fail-fast=true). Consider explicitly disabling fail-fast for resilience.

Apply this diff near the matrix definition:

     strategy:
+      fail-fast: false
       matrix:
         nginx_version:
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 39c105a and 8d780d4.

📒 Files selected for processing (1)
  • .github/workflows/ci.yml (1 hunks)
🔇 Additional comments (1)
.github/workflows/ci.yml (1)

64-65: NGINX 1.29.0 and 1.29.1 added — upstream tarballs reachable; please verify Dockerfile

Both nginx.org source tarballs exist (HTTP 200) with non-trivial sizes — change looks correct and keeps ascending order.

LGTM from an upstream-tarball perspective. Please also verify your Dockerfile/build logic (patch application, configure flags, pinned checksums, etc.) supports 1.29.x without causing build or test regressions.

@lucacome lucacome merged commit ef132b8 into master Aug 16, 2025
37 of 38 checks passed
@lucacome lucacome deleted the feat/modules branch August 16, 2025 01:55
@coderabbitai coderabbitai bot mentioned this pull request Sep 4, 2025
@coderabbitai coderabbitai bot mentioned this pull request Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant