Use foreach

Author: leonardehrenfried

application/src/main/java/org/opentripplanner/updater/trip/gtfs/GtfsRealTimeTripUpdateAdapter.java

@@ -125,11 +125,9 @@ public UpdateResult applyTripUpdates(
       snapshotManager.clearBuffer(feedId);
     }
 
-    for (var i = 0; i < updates.size(); ++i) {
+    for (var rawTripUpdate : updates) {
       Result<UpdateSuccess, UpdateError> result;
       try {
-        var rawTripUpdate = updates.get(i);
-
         if (fuzzyTripMatcher != null) {
           var trip = fuzzyTripMatcher.match(feedId, rawTripUpdate.getTrip());
           rawTripUpdate = rawTripUpdate.toBuilder().setTrip(trip).build();
@@ -145,10 +143,10 @@ public UpdateResult applyTripUpdates(
         }
 
         result = applyUpdate(
-          forwardsDelayPropagationType,
-          backwardsDelayPropagationType,
+          tripUpdate,
           updateIncrementality,
-          tripUpdate
+          backwardsDelayPropagationType,
+          forwardsDelayPropagationType
         );
 
         if (result.isFailure()) {
@@ -174,10 +172,10 @@ public UpdateResult applyTripUpdates(
   }
 
   private Result<UpdateSuccess, UpdateError> applyUpdate(
-    ForwardsDelayPropagationType forwardsDelayPropagationType,
-    BackwardsDelayPropagationType backwardsDelayPropagationType,
+    TripUpdate tripUpdate,
     UpdateIncrementality updateIncrementality,
-    TripUpdate tripUpdate
+    BackwardsDelayPropagationType backwardsDelayPropagationType,
+    ForwardsDelayPropagationType forwardsDelayPropagationType
   ) {
     return switch (tripUpdate.scheduleRelationship()) {
       case SCHEDULED -> handleScheduledTrip(