Remove OtpError implementation

Author: leonardehrenfried

application/src/main/java/org/opentripplanner/updater/spi/DataValidationExceptionMapper.java

@@ -4,7 +4,6 @@
 import org.opentripplanner.transit.model.framework.DataValidationException;
 import org.opentripplanner.transit.model.framework.Result;
 import org.opentripplanner.transit.model.timetable.TimetableValidationError;
-import org.opentripplanner.updater.trip.gtfs.model.InvalidTripError;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
@@ -29,9 +28,6 @@ public static <T> Result<T, UpdateError> toResult(
         new UpdateError(tt.trip().getId(), mapTimeTableError(tt.code()), tt.stopIndex(), producer)
       );
     }
-    if (error.error() instanceof InvalidTripError e) {
-      return Result.failure(new UpdateError(e.tripId(), e.code(), null, producer));
-    }
     // The mapper should handle all possible errors
     LOG.error("Unhandled error: {}", error.getMessage(), error);
     return Result.failure(UpdateError.noTripId(UpdateError.UpdateErrorType.UNKNOWN));

application/src/main/java/org/opentripplanner/updater/trip/gtfs/GtfsRealTimeTripUpdateAdapter.java

@@ -146,8 +146,12 @@ public UpdateResult applyTripUpdates(
           rawTripUpdate = rawTripUpdate.toBuilder().setTrip(trip).build();
         }
 
-        // throws exception when invalid
         var tripUpdate = new TripUpdate(feedId, rawTripUpdate, localDateNow);
+        var validationResult = tripUpdate.validate();
+        if (validationResult.isFailure()) {
+          results.add(validationResult.toFailureResult());
+          continue;
+        }
 
         // Determine what kind of trip update this is
         var scheduleRelationship = tripUpdate.scheduleRelationship();

application/src/main/java/org/opentripplanner/updater/trip/gtfs/model/InvalidTripError.java

@@ -15,6 +15,9 @@
 import org.opentripplanner.core.model.id.FeedScopedId;
 import org.opentripplanner.transit.model.basic.Accessibility;
 import org.opentripplanner.transit.model.framework.DataValidationException;
+import org.opentripplanner.transit.model.framework.Result;
+import org.opentripplanner.updater.spi.UpdateError;
+import org.opentripplanner.updater.spi.UpdateSuccess;
 
 /**
  * A real-time update for trip, which may contain updated stop times and trip properties.
@@ -37,7 +40,6 @@ public TripUpdate(
     this.tripUpdate = tripUpdate;
     this.tripDescriptor = new TripDescriptor(tripUpdate.getTrip());
     this.localDateNow = localDateNow;
-    this.validate();
   }
 
   public TripDescriptor descriptor() {
@@ -105,16 +107,17 @@ public FeedScopedId tripId() {
       );
   }
 
-  private void validate() throws DataValidationException {
+  public Result<UpdateSuccess, UpdateError> validate() throws DataValidationException {
     if (tripDescriptor.tripId().isEmpty()) {
-      throw new DataValidationException(new InvalidTripError(null, INVALID_INPUT_STRUCTURE));
+      return Result.failure(UpdateError.noTripId(INVALID_INPUT_STRUCTURE));
     }
 
     try {
       tripDescriptor.startDate();
     } catch (ParseException e) {
-      throw new DataValidationException(new InvalidTripError(tripId(), INVALID_INPUT_STRUCTURE));
+      return Result.failure(new UpdateError(tripId(), INVALID_INPUT_STRUCTURE));
     }
+    return Result.success(UpdateSuccess.noWarnings());
   }
 
   public Optional<FeedScopedId> routeId() {