Add test for vertex linker

Author: leonardehrenfried

application/src/main/java/org/opentripplanner/routing/linking/VertexLinker.java

@@ -425,10 +425,7 @@ private StreetVertex snapAndLink(
     }
 
     if (OTPFeature.FlexRouting.isOn()) {
-      var areaStops = Stream.concat(
-        start.getIncomingStreetEdges().stream(),
-        start.getOutgoing().stream()
-      )
+      var areaStops = Stream.concat(start.getIncoming().stream(), start.getOutgoing().stream())
         .flatMap(e ->
           Stream.concat(
             e.getFromVertex().areaStops().stream(),

application/src/test/java/org/opentripplanner/routing/linking/VertexLinkerTest.java

@@ -1,26 +1,64 @@
 package org.opentripplanner.routing.linking;
 
-import static org.junit.jupiter.api.Assertions.*;
+import static com.google.common.truth.Truth.assertThat;
 
+import java.util.List;
+import java.util.Set;
 import org.junit.jupiter.api.Test;
+import org.opentripplanner.framework.application.OTPFeature;
 import org.opentripplanner.routing.graph.Graph;
 import org.opentripplanner.street.model._data.StreetModelForTest;
-import org.opentripplanner.test.support.GeoJsonIo;
+import org.opentripplanner.street.model.edge.LinkingDirection;
+import org.opentripplanner.street.model.vertex.SplitterVertex;
+import org.opentripplanner.street.model.vertex.StreetVertex;
+import org.opentripplanner.street.search.TraverseModeSet;
+import org.opentripplanner.transit.model._data.TimetableRepositoryForTest;
+import org.opentripplanner.transit.model.site.AreaStop;
 
 class VertexLinkerTest {
 
+  public static final TimetableRepositoryForTest REPO = TimetableRepositoryForTest.of();
+  public static final AreaStop AREA_STOP_1 = REPO.areaStop("area-stop-1").build();
+  public static final AreaStop AREA_STOP_2 = REPO.areaStop("area-stop-2").build();
+
   @Test
   void flex() {
-    var v1 = StreetModelForTest.intersectionVertex(0, 0);
-    var v2 = StreetModelForTest.intersectionVertex(0.1, 0.1);
-    var edge = StreetModelForTest.streetEdge(v1, v2);
+    OTPFeature.FlexRouting.testOn(() -> {
+      var v1 = StreetModelForTest.intersectionVertex(0, 0);
+      v1.addAreaStops(Set.of(AREA_STOP_1));
+      var v2 = StreetModelForTest.intersectionVertex(0.1, 0.1);
+      v2.addAreaStops(Set.of(AREA_STOP_2));
+
+      var toBeLinked = StreetModelForTest.intersectionVertex(0.05, 0.06);
+
+      assertThat(toBeLinked.areaStops()).isEmpty();
+
+      StreetModelForTest.streetEdge(v1, v2);
+
+      var graph = new Graph();
+
+      graph.addVertex(v1);
+      graph.addVertex(v2);
+      graph.index();
+
+      var linker = new VertexLinker(graph);
 
-    var graph = new Graph();
+      linker.linkVertexPermanently(
+        toBeLinked,
+        TraverseModeSet.allModes(),
+        LinkingDirection.BIDIRECTIONAL,
+        (vertex, streetVertex) ->
+          List.of(
+            StreetModelForTest.streetEdge((StreetVertex) vertex, streetVertex),
+            StreetModelForTest.streetEdge(streetVertex, (StreetVertex) vertex)
+          )
+      );
 
-    graph.addVertex(v1);
-    graph.addVertex(v2);
-    graph.index();
+      var splitterVertices = graph.getVerticesOfType(SplitterVertex.class);
+      assertThat(splitterVertices).hasSize(1);
+      var splitter = splitterVertices.getFirst();
 
-    System.out.println(GeoJsonIo.toUrl(graph));
+      assertThat(splitter.areaStops()).containsExactly(AREA_STOP_1, AREA_STOP_2);
+    });
   }
 }