Apply review feedback

Author: leonardehrenfried

utils/src/main/java/org/opentripplanner/utils/collection/IndexedListElement.java

@@ -1,6 +1,7 @@
 package org.opentripplanner.utils.collection;
 
 import java.util.Objects;
+import org.opentripplanner.utils.tostring.ValueObjectToStringBuilder;
 
 /**
  * A small container for an element and its index in a list.
@@ -39,4 +40,15 @@ public boolean equals(Object obj) {
   public int hashCode() {
     return Objects.hash(index, element);
   }
+
+  @Override
+  public String toString() {
+    return ValueObjectToStringBuilder.of()
+      .addText("[")
+      .addNum(index)
+      .addText("=")
+      .addObj(element)
+      .addText("]")
+      .toString();
+  }
 }

utils/src/test/java/org/opentripplanner/utils/collection/ListUtilsTest.java

@@ -138,5 +138,7 @@ void indexedList() {
       ),
       indexed
     );
+
+    assertEquals("[0=A]", indexed.getFirst().toString());
   }
 }

utils/src/test/java/org/opentripplanner/utils/collection/StreamUtilsTest.java

@@ -8,22 +8,22 @@
 class StreamUtilsTest {
 
   @Test
-  void nullable() {
+  void nullableCollection() {
     assertEquals(List.of(), StreamUtils.ofNullableCollection(null).toList());
   }
 
   @Test
-  void emptyList() {
+  void nullableCollectionEmptyList() {
     assertEquals(List.of(), StreamUtils.ofNullableCollection(List.of()).toList());
   }
 
   @Test
-  void oneElement() {
+  void nullableCollectionOneElement() {
     assertEquals(List.of(1), StreamUtils.ofNullableCollection(List.of(1)).toList());
   }
 
   @Test
-  void twoElements() {
+  void nullableCollectionTwoElements() {
     assertEquals(List.of(1, 2), StreamUtils.ofNullableCollection(List.of(1, 2)).toList());
   }
 }