Apply review suggestions

Author: vpaturet

src/main/java/org/opentripplanner/transit/service/TransitEditorService.java

@@ -39,9 +39,22 @@ void addTripOnServiceDateForTripAndDay(
 
   FeedScopedId getOrCreateServiceIdForDate(LocalDate serviceDate);
 
+  /**
+   * Set the original, immutable, transit layer,
+   * based on scheduled data (not real-time data).
+   */
   void setTransitLayer(TransitLayer transitLayer);
 
+  /**
+   * Return true if a real-time transit layer is present.
+   * The real-time transit layer is optional,
+   * it is present only when real-time updaters are configured.
+   */
   boolean hasRealtimeTransitLayer();
 
+  /**
+   * Publish the latest snapshot of the real-time transit layer.
+   * Should be called only when creating a new TransitLayer, from the graph writer thread.
+   */
   void setRealtimeTransitLayer(TransitLayer realtimeTransitLayer);
 }

src/main/java/org/opentripplanner/updater/vehicle_position/PollingVehiclePositionUpdater.java

@@ -45,6 +45,8 @@ public PollingVehiclePositionUpdater(
     super(params);
     this.vehiclePositionSource =
       new GtfsRealtimeHttpVehiclePositionSource(params.url(), params.headers());
+    // TODO Inject TransitService, do not create it here. We currently do not
+    //      support dagger injection in updaters, so this is ok for now.
     TransitService transitService = new DefaultTransitService(transitModel);
     var fuzzyTripMatcher = params.fuzzyTripMatching()
       ? new GtfsRealtimeFuzzyTripMatcher(transitService)