Island pruning limited to origin islands, not destination islands

[abyrd]

Expected behavior

Small connected components should be removed from the graph to correct for poor tagging in OSM input data. It should be possible to route into or out of any area (there should not be areas that are unreachable or that cannot be exited).

Observed behavior

The island pruning graph builder does not seem to handle cases where it's impossible to get into an area. Our example is a parking lot on the Dutch island of Texel, which is essentially a one-way loop. The entrance way was tagged such that it was forbidden to motor vehicles. It was possible to start a car trip from this parking lot but not end a car trip in the same parking lot.

Version of OTP used (exact commit hash or JAR name)

Current head of master, 210b2b3

Data sets in use (links to GTFS and OSM PBF files)

• OSM data from http://download.geofabrik.de/europe/netherlands.html
• Realtime Flex transit service in stopgap GBFS format, pulled in by the router config shown below.
• No GTFS-based public transit.

Command line used to start OTP

• -Xmx8G --build otp/graphs/texel
• -Xmx8G --graphs otp/graphs/ --router texel --server

Router config and graph build config JSON

~/otp/graphs/texel $ cat router-config.json
{
    "routingDefaults": {
        "numItineraries": 6,
        "walkSpeed": 2.0,
        "stairsReluctance": 4.0,
        "carDropoffTime": 240,
        "waitAtBeginningFactor": 0.3
    },

    "timeouts": [5, 4, 2],

    "updaters": [
	{
            "frequencySec": 3600,
            "type": "bike-rental",
            "sourceType": "gbfs",
	    "routeAsCar": true,
            "url": "http://gbfs.openov.nl/overal-flex/"
        },
	{
            "frequencySec": 3600,
            "type": "bike-rental",
            "sourceType": "gbfs",
	    "routeAsCar": true,
            "url": "http://gbfs.openov.nl/texelhopper/"
        }
    ]
}

Steps to reproduce the problem

Plan a car trip into the parking lot at (53.00449, 4.78128). It should fail with no available itineraries. Planning a trip out of the same parking lot succeeds.

[github-actions]

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 30 days