reluctanceForMode uses route mode, not Trip/pattern #5248
Description
Example router config:
"transitReluctanceForMode": {
"RAIL": 0.85,
"BUS": 1.0
}When reducing the reluctance for RAIL I would expect it to be applied to all Trips with RAIL mode, and not rail replacement busses. It turns out that OTP uses the Route(Line) mode, not the trip(ServiceJourney) mode. This might be ok in some usecases, but it is not documented and I believe it is confusing.
When fixing issue #3665, we should take this into account and make a better/more flexible model addressing this. We should consider removing the "transitReluctanceForMode" config parameter and support grouping by both Route and Trip mode/submode.