Quality improvements - Berlin 2024

[t2gran]

We will set aside some time to work on technical dept in OTP during the OTP developer days in Berlin in October 2024. We will use this issue to list task. If you have something you know about, please add it to the list. If you do not have access to edit this list, just add a comment and I can add it to the list.

Tasks

• Move the Siri sandbox code into OTP main source branch. @vpaturet
• Move Raptor into a separate Maven module.
• Go through the naming-conventions and search through OTP and fix code that it does not follow it. Examples: TimetableSnapshot
• Make Osm/OSM/OpenStreetMap type names consistent
• Make GtfsRealTime/GtfsRt type names consistent
• Fix names in TimetableSnapshot.java @vpaturet
• TransitModel#addRoutes adds a single route so shouldn't be plural
• Find a good name for TransitLayer (need to decide beforehand)
• Rename Stop Model to Site Repository
• Rename Transit Model to Timetable Repository
• Rename Graph to Street Repository - discuss this first.
• Look at the Dagger dependency injection PR. Rebase, make it work.
• Make (part of) RouteRequest immutable @tobsesHub
• @nullable, mark things as nullable
• Update broken links in the documentation
• StopPatternServiceDateKey 2 classes in the same file
• Fix Add via to the Transmodel trip query and make a proper Raptor implementation for it #6084 (comment)

[tobsesHub]

I guess, that it makes sense, that the "Make (part of) RouteRequest immutable" task will be done by someone more experienced because doing that, requires a lot of changes.