Plan via visit stations does not work when the stations are on my normal reasonable route

[miklcct]

NOTE: this issue system is intended for reporting bugs and tracking progress in software
development. For all other usage and software development questions or discussion, please post a
question in our chat room: https://gitter.im/opentripplanner/OpenTripPlanner.

Expected behavior

It return journeys which changes at the specified station.

Observed behavior

It return journeys which merely pass through, or even without passing through, the specified station.

Version of OTP used (exact commit hash or JAR name)

2.7.0-SNAPSHOT

Data sets in use (links to GTFS and OSM PBF files)

London trains and tubes

Command line used to start OTP

Router config and graph build config JSON

ConsiderPatternsForDirectTransfers is on
TransferConstraints is off

Steps to reproduce the problem

Plan a journey from London Fields to Willesden Green.

There are two normal routes:
Weaver to Liverpool Street, Metropolitan to Finchley Road and Jubilee to Willesden Green
Walk to Hackney Central, Mildmay to West Hampstead (Overground), walk to West Hampstead (Underground), Jubilee to Willesden Green

I add a visit point at Finchley Road & Frognal.
The expected result is to alight Mildmay at Finchley Road & Frognal, walk to Finchley Road and take the Jubilee, but the journey planner still tells me to change at West Hampstead.

I add a visit point at Finchley Road (Underground) instead of the above, the expected result is to only return the routes using the Metropolitan line by changing there, but some of the results still tell me to take the Mildmay to West Hampstead, which doesn't even pass through the station I want to visit.

Note that this problem does not appear if the normal reasonable routes do not pass through the stations I want to visit. The problem only appears if I want to force the change points to be different from the normal one. In the Mildmay - Jubilee example, the normal change point is West Hampstead but it is also possible at Finchley Road or Kilburn / Brondesbury.

Details to be added later

[miklcct]

I am now trying to plan a journey from Wembley Park to Aylesbury. The normal route is to change at Harrow on the Hill for Chiltern Railways. Therefore it will tell me to take the latest available Metropolitan line train (which may head elsewhere than Amersham) to change at Harrow on the Hill, as the Metropolitan is less frequent beyond Harrow on the Hill, and Chiltern Railways is faster than Metropolitan between Harrow on the Hill and Amersham.

However, I want to force a change at Amersham (because I know that it is much cheaper to use my Oyster card all the way to Amersham, and I have to leave the train to touch out there before continuing my journey to the world outside Oyster - the server doesn't have any fare information yet), so I specify Amersham as a visit station. It now correctly tells me to take an earlier Metropolitan line which terminates at Amersham, however, it still tells me to change at Harrow on the Hill, which is clearly wrong.

[t2gran]

@miklcct Can you test this with #6449 - I hope this should fix the problem - it is not implemented support for via in otimized transfers jey.

[github-actions]

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 30 days

[miklcct]

I believe this has been fixed by #6449