Skip to content

Commit 9c47492

Browse files
committed
refactor(i18n): Address PR comments
1 parent 62669eb commit 9c47492

10 files changed

+215
-168
lines changed

Diff for: i18n/en-US.yml

+110-86
Original file line numberDiff line numberDiff line change
@@ -33,31 +33,36 @@ components:
3333
AmenitiesPanel:
3434
noPRLotsFound: No nearby park and ride lots found.
3535
# Use plurals to differentiate between company variable being set or not
36-
bikesAtStation: "{companyLength, plural,
37-
=0 {Bikes at {name}}
38-
other {{company} bikes at {name}}
39-
}"
40-
bikesNearby: "{count, plural,
41-
=0 {no floating {company} bikes nearby}
42-
one {{count} floating {company} bike nearby}
43-
other {{count} floating {company} bikes nearby}
44-
}"
45-
bikesAvailable: "{count, plural,
46-
=0 {No bikes available}
47-
one {{count} bike available}
48-
other {{count} bikes available}
49-
}"
50-
spacesAvailable: "{count, plural,
51-
=0 {No spaces available}
52-
one {{count} space available}
53-
other {{count} spaces available}
54-
}"
36+
bikesAtStation: >
37+
{companyLength, plural,
38+
=0 {Bikes at {name}}
39+
other {{company} bikes at {name}}
40+
}
41+
bikesNearby: >
42+
{count, plural,
43+
=0 {no floating {company} bikes nearby}
44+
one {{count} floating {company} bike nearby}
45+
other {{count} floating {company} bikes nearby}
46+
}
47+
bikesAvailable: >
48+
{count, plural,
49+
=0 {No bikes available}
50+
one {{count} bike available}
51+
other {{count} bikes available}
52+
}
53+
spacesAvailable: >
54+
{count, plural,
55+
=0 {No spaces available}
56+
one {{count} space available}
57+
other {{count} spaces available}
58+
}
5559
noNearbyBikes: No nearby bike rentals found.
56-
scootersNearby: "{count, plural,
57-
=0 {No {company} E-Scooters nearby}
58-
one {{count} {company} E-Scooter nearby}
59-
other {{count} {company} E-Scooters nearby}
60-
}"
60+
scootersNearby: >
61+
{count, plural,
62+
=0 {No {company} E-Scooters nearby}
63+
one {{count} {company} E-Scooter nearby}
64+
other {{count} {company} E-Scooters nearby}
65+
}
6166
noNearbyScooters: No nearby micromobility rentals found.
6267
nearbyAmenities: Nearby Amenities
6368
AppMenu:
@@ -73,8 +78,9 @@ components:
7378
shortTitle: Plan Trip
7479
BeforeSignInScreen:
7580
mainTitle: Signing you in
76-
message: "In order to access this page you will need to sign in.
77-
Please wait while we redirect you to the login page..."
81+
message: >
82+
In order to access this page you will need to sign in.
83+
Please wait while we redirect you to the login page...
7884
DefaultItinerary:
7985
clickDetails: Click to view details
8086
# Use ordered placeholders when multiple modes are involved
@@ -107,52 +113,56 @@ components:
107113
placeNotFound: Place not found
108114
placeNotFoundDescription: Sorry, the requested place was not found.
109115
FavoritePlacesList:
110-
description: Add the places you frequent often to save time planning trips:
116+
description: "Add the places you frequent often to save time planning trips:"
111117
FormNavigationButtons:
112118
ariaLabel: Form navigation
113119
# If trip is less than one hour only display the minutes.
114120
tripDurationFormatZeroHours: "{minutes, number} min"
115121
# TODO: Distinguish between one hour (singular) and 2 hours or more?
116122
tripDurationFormat: "{hours, number} hr {minutes, number} min"
117123
ItinerarySummary:
118-
fareCost: "{useMaxFare, select,
119-
true {{minTotalFare} - {maxTotalFare}}
120-
other {{minTotalFare}}
121-
}"
124+
fareCost: >
125+
{useMaxFare, select,
126+
true {{minTotalFare} - {maxTotalFare}}
127+
other {{minTotalFare}}
128+
}
122129
LiveStopTimes:
123130
routeToHeadsign: "To {headsign}"
124131
NarrativeItinerariesHeader:
125-
numIssues: "{issueNum, number} {issueNum, plural,
126-
one {issue}
127-
other {issues}
128-
}"
132+
numIssues: >
133+
{issueNum, number} {issueNum, plural,
134+
one {issue}
135+
other {issues}
136+
}
129137
# Note to translator: resultText is width-constrained
130138
# (about half pane width)
131-
resultText: "{pending, select,
132-
true {Finding your options...}
133-
other {{itineraryNum, number} {itineraryNum, plural,
134-
one {itinerary found}
135-
other {itineraries found}
136-
}}
137-
}"
139+
resultText: >
140+
{pending, select,
141+
true {Finding your options...}
142+
other {{itineraryNum, number} {itineraryNum, plural,
143+
one {itinerary found}
144+
other {itineraries found}
145+
}}
146+
}
138147
selectArrivalTime: Arrival time
139148
selectBest: Best option
140149
selectCost: Cost
141150
selectDepartureTime: Departure time
142151
selectDuration: Duration
143152
selectWalkTime: Walk time
144-
titleText: "{pending, select,
145-
true {Finding your options...}
146-
other {
147-
{itineraryNum, number} {itineraryNum, plural,
148-
one {itinerary}
149-
other {itineraries}} {issueNum, plural,
150-
=0 {found}
151-
one {(and {issueNum, number} issue) found}
152-
other {(and {issueNum,number} issues) found}
153+
titleText: >
154+
{pending, select,
155+
true {Finding your options...}
156+
other {
157+
{itineraryNum, number} {itineraryNum, plural,
158+
one {itinerary}
159+
other {itineraries}} {issueNum, plural,
160+
=0 {found}
161+
one {(and {issueNum, number} issue) found}
162+
other {(and {issueNum,number} issues) found}
163+
}
153164
}
154-
}
155-
}"
165+
}
156166
viewAll: View all options
157167
NavLoginButton:
158168
help: Help
@@ -169,9 +179,8 @@ components:
169179
description: You can receive notifications about trips you frequently take.
170180
notificationChannelPrompt: How would you like to receive notifications?
171181
notificationEmailDetail: "Notification emails will be sent to:"
172-
emailSelect: Email
173182
noneSelect: Don't notify me
174-
smsSelect: SMS
183+
175184
PhoneNumberEditor:
176185
changeNumber: Change number
177186
invalidCode: Please enter 6 digits for the validation code.
@@ -185,9 +194,10 @@ components:
185194
smsDetail: "SMS notifications will be sent to:"
186195
verified: Verified
187196
verificationCode: "Verification code:"
188-
verificationInstructions: "Please check the SMS messaging app on your mobile phone
197+
verificationInstructions: >
198+
Please check the SMS messaging app on your mobile phone
189199
for a text message with a verification code, and enter the code below
190-
(code expires after 10 minutes)."
200+
(code expires after 10 minutes).
191201
verify: Verify
192202
PlaceEditor:
193203
genericLocationPlaceholder: Search for location
@@ -201,11 +211,13 @@ components:
201211
previous: Previous
202212
RealtimeAnnotation:
203213
applyServiceDelays: Apply service delays
204-
delaysNotShownInResults: "Your trip results are currently being affected by service delays.
205-
These delays do not factor into travel times shown below."
206-
delaysShownInResults: "Your trip results have been adjusted based on real-time
214+
delaysNotShownInResults: >
215+
Your trip results are currently being affected by service delays.
216+
These delays do not factor into travel times shown below.
217+
delaysShownInResults: >
218+
Your trip results have been adjusted based on real-time
207219
information. Under normal conditions, this trip would take <strong>{normalDuration}</strong>
208-
using the following routes: {routes}."
220+
using the following routes: {routes}.
209221
ignoreServiceDelays: Ignore service delays
210222
serviceUpdate: Service update
211223
RelatedPanel:
@@ -249,8 +261,9 @@ components:
249261
pause: Pause
250262
resume: Resume
251263
SavedTripScreen:
252-
tooManyTrips: "You already have reached the maximum of five saved trips.
253-
Please remove unused trips from your saved trips, and try again."
264+
tooManyTrips: >
265+
You already have reached the maximum of five saved trips.
266+
Please remove unused trips from your saved trips, and try again.
254267
tripNameAlreadyUsed: Another saved trip already uses this name. Please choose a different name.
255268
tripNameRequired: Please enter a trip name.
256269
SaveTripButton:
@@ -269,16 +282,19 @@ components:
269282
trips: Trips
270283
TabbedItineraries:
271284
optionNumber: "Option {optionNum, number}"
272-
fareCost: "{hasMaxFare, select,
273-
true {{minTotalFare}+}
274-
other {{minTotalFare}}
275-
}"
285+
fareCost: >
286+
{hasMaxFare, select,
287+
true {{minTotalFare}+}
288+
other {{minTotalFare}}
289+
}
276290
TermsOfUsePane:
277291
mustAgreeToTerms: You must agree to the terms of service to continue.
278-
termsOfServiceStatement: "I confirm that I am at least 18 years old, and I have read and
279-
consent to the <termsOfUseLink>Terms of service</termsOfUseLink > for using the Trip Planner."
280-
termsOfStorageStatement: "Optional: I consent to the Trip Planner storing my historical planned trips in order to
281-
improve transit services in my area. <termsOfStorageLink>More info...</termsOfStorageLink>"
292+
termsOfServiceStatement: >
293+
I confirm that I am at least 18 years old, and I have read and
294+
consent to the <termsOfUseLink>Terms of service</termsOfUseLink > for using the Trip Planner.
295+
termsOfStorageStatement: >
296+
Optional: I consent to the Trip Planner storing my historical planned trips in order to
297+
improve transit services in my area. <termsOfStorageLink>More info...</termsOfStorageLink>
282298
TransitVehicleOverlay:
283299
# keys designed to match API output
284300
incoming_at: "approaching {stop}"
@@ -302,9 +318,9 @@ components:
302318
advancedSettings: Advanced settings
303319
altRouteRecommended: An alternative route or transfer point is recommended
304320
delaysAboveThreshold: There are delays or disruptions of more than
305-
emailChannel: email
306-
howToReceiveAlerts: "To receive alerts for your saved trips, enable notifications
307-
in your account settings, and try saving a trip again."
321+
howToReceiveAlerts: >
322+
To receive alerts for your saved trips, enable notifications
323+
in your account settings, and try saving a trip again.
308324
monitorThisTrip: Monitor this trip {minutes} before it begins until it ends.
309325
notificationsTurnedOff: Notifications are turned off for your account.
310326
# Note to translator: The notifyViaChannelWhen message, combined with
@@ -313,7 +329,6 @@ components:
313329
notifyViaChannelWhen: "Notify me via {channel} when:"
314330
oneHour: 1 hour
315331
realtimeAlertFlagged: There is a realtime alert flagged on my journey
316-
smsChannel: SMS
317332
TripStatus:
318333
alerts: "{alerts, plural, one {{alerts} alert!} other {{alerts} alerts!}}"
319334
deleteTrip: Delete Trip
@@ -337,12 +352,14 @@ components:
337352
description: Resume trip monitoring to see the updated status
338353
heading: Trip monitoring is paused
339354
nextTripNotPossible:
340-
description: "The trip planner was unable to find your trip today.
341-
Please try re-planning your itinerary to find an alternative route."
355+
description: >
356+
The trip planner was unable to find your trip today.
357+
Please try re-planning your itinerary to find an alternative route.
342358
heading: Trip is not possible today
343359
noLongerPossible:
344-
description: "The trip planner was unable to find your trip on any selected days of the week.
345-
Please try re-planning your itinerary to find an alternative route."
360+
description: >
361+
The trip planner was unable to find your trip on any selected days of the week.
362+
Please try re-planning your itinerary to find an alternative route.
346363
heading: Trip is no longer possible
347364
notCalculated:
348365
awaiting: Awaiting calculation...
@@ -373,16 +390,18 @@ components:
373390
print: Print
374391
reportIssue: Report Issue
375392
reportEmailSubject: Reporting an Issue with OpenTripPlanner
376-
reportEmailTemplate: " *** INSTRUCTIONS TO USER ***
393+
reportEmailTemplate: >
394+
***INSTRUCTIONS TO USER***
377395
This feature allows you to email a report to site administrators for review.
378396
Please add any additional feedback for this trip under the 'Additional Comments'
379-
section below and send using your regular email program."
397+
section below and send using your regular email program.
380398
UserAccountScreen:
381399
confirmDelete: Are you sure you would like to delete your user account? Once you do so, it cannot be recovered.
382400
VerifyEmailPane:
383401
emailIsVerified: My email is verified!
384-
instructions1: "Please check your email inbox and follow the link in the message
385-
to verify your email address before finishing your account setup."
402+
instructions1: >
403+
Please check your email inbox and follow the link in the message
404+
to verify your email address before finishing your account setup.
386405
instructions2: Once you're verified, click the button below to continue.
387406
resendVerification: Resend verification email
388407

@@ -441,6 +460,10 @@ common:
441460
noItineraryToDisplay: No itinerary to display.
442461
transfers: "{transfers, plural, =0 {} one {{transfers} transfer} other {{transfers} transfers}}"
443462

463+
notifications:
464+
email: email
465+
sms: SMS
466+
444467
# OTP transit modes
445468
# Note that identifiers are OTP modes converted to lowercase.
446469
otpTransitModes:
@@ -462,9 +485,10 @@ common:
462485
# Use ordered placeholders for the departure-arrival string
463486
# (this will accommodate right-to-left languages by swapping the order in this string).
464487
departureArrivalTimes: "{startTime, time, short}—{endTime, time, short}"
465-
tripDurationFormat: "{hours, plural,
466-
=0 {{minutes, number} min}
467-
other {{hours, number} hr {minutes, number} min}}"
488+
tripDurationFormat: >
489+
{hours, plural,
490+
=0 {{minutes, number} min}
491+
other {{hours, number} hr {minutes, number} min}}
468492
# If trip is less than one hour only display the minutes.
469493
tripDurationFormatZeroHours: "{minutes, number} min"
470494

0 commit comments

Comments
 (0)