add stations support to nearby view #1371
Conversation
miles-grant-ibigroup
assigned daniel-heppner-ibigroup and unassigned miles-grant-ibigroup
- remove rounded corners on pattern rows - hide parent schedule if there are child stops - improve styling/shadows - move view schedule button to child stop headers for stations
|
I think I made some big improvements in the latest commit, let me know what you think. I'm still not sure about the styling for the headers. |
| @@ -59,11 +60,11 @@ const renderDay = (homeTimezone: string, day: number): JSX.Element => { | |||
| * Represents a single pattern row for displaying arrival times in the stop | |||
| * viewer. | |||
| */ | |||
| // eslint-disable-next-line complexity | |||
There was a problem hiding this comment.
I think this can be dropped now
There was a problem hiding this comment.
still needed
There was a problem hiding this comment.
Are you sure
daniel-heppner-ibigroup
assigned miles-grant-ibigroup and unassigned daniel-heppner-ibigroup
| @@ -59,11 +60,11 @@ const renderDay = (homeTimezone: string, day: number): JSX.Element => { | |||
| * Represents a single pattern row for displaying arrival times in the stop | |||
| * viewer. | |||
| */ | |||
| // eslint-disable-next-line complexity | |||
There was a problem hiding this comment.
Are you sure
miles-grant-ibigroup
assigned daniel-heppner-ibigroup and unassigned miles-grant-ibigroup
daniel-heppner-ibigroup
force-pushed
the
nearby-view-stations-basedev
branch
from
7a0dac4 to
a5b566c
Compare
daniel-heppner-ibigroup
assigned amy-corson-ibigroup and unassigned daniel-heppner-ibigroup
There was a problem hiding this comment.
This looks great, thank you so much for the changes! How would we feel about upping the top/bottom padding on the label, increasing the margin between the first label and the "departure times" notice, and adding either a border or a background color? I think the first stop label is bleeding into the station card, adding a little separation could make it a little clearer:
| Now | Border | Background |
|---|---|---|
 |
 |
 |
(Requesting changes for the convo but nothing technically blocking here, so if we decide to keep as is I'll approve)
| <FormattedMessage id="components.StopViewer.viewSchedule" /> | ||
| !isParentStop ? ( | ||
| <FormattedMessage id="components.StopViewer.viewSchedule" /> | ||
| ) : undefined | ||
| } | ||
| fromToSlot={fromToSlot} | ||
| stopData={stopData} | ||
| /> | ||
| <div> | ||
| <div>{timezoneWarning}</div> |
There was a problem hiding this comment.
Could we add a margin-bottom: 1rem on the departure timezone notice? I think it could help the overall spacing (not just for stations) because it matches the margin between it and the from/to picker.
| Station | Stops |
|---|---|
 |
 |
There was a problem hiding this comment.
I feel like that is too much whitespace tbh, not a fan. Especially because it's repeated on each card, it is a lot of extra space for something that isn't that important.
I love the bigger border and the centering! The gray background I have some reservations about (maybe something transparent instead?) but I think that should wait for a future PR! |
…nner/otp-react-redux into nearby-view-stations-basedev
daniel-heppner-ibigroup
assigned amy-corson-ibigroup and unassigned daniel-heppner-ibigroup
|
I liked the border proposal more too, so I added a thin border to the top. Let me know if it's good! |
…nner/otp-react-redux into nearby-view-stations-basedev
daniel-heppner-ibigroup
assigned miles-grant-ibigroup and unassigned daniel-heppner-ibigroup
miles-grant-ibigroup
assigned daniel-heppner-ibigroup and unassigned miles-grant-ibigroup
Description:
Adds support for Stations with sub-stops in nearby view. This version is based on dev instead of the scooter merging.