Fares V2 Support #1461
Open
Fares V2 Support #1461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # package.json # yarn.lock
Repair Percy Tests After Geocoder Changes
|
This is now ready for review @daniel-heppner-ibigroup |
# Conflicts: # yarn.lock
3 tasks
daniel-heppner-ibigroup
requested changes
Oct 21, 2025
|
|
||
| if ( | ||
| // Display special message if there are multiple fare products, but no primary product configured | ||
| // @ts-expect-error TS seems to not understand the optional? |
There was a problem hiding this comment.
TS understands the optional, but you you can't use a > operator on undefined because it needs two numbers. So you need to provide a default value for leg.fareProducts?.length by using ?? 0 or something. Or do a null check some other way.
daniel-heppner-ibigroup
assigned
miles-grant-ibigroup and unassigned
daniel-heppner-ibigroup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Uses new core utils functions to support new Fares V2 Table and display
PR Checklist: