Handle no pattern headsign #1499
Conversation
amy-corson-ibigroup
left a comment
amy-corson-ibigroup
left a comment
There was a problem hiding this comment.
Really nice improvement, thank you for all the different considerations on this! Just a few nitpicks/questions but overall looks good.
lib/util/viewer.js
Outdated
| // In case the headsign is blank, extract headsign from the pattern 'desc' attribute | ||
| // by attempting the logic below in order: | ||
| const attempts = [ | ||
| // (format: '49 to <Destination> (<destid>)[ from <Origin> (<originid)]'). |
There was a problem hiding this comment.
This is a nitpick, but can we remove the parenthesis around this comment? There's a lot of brackets and parenthesis happening in this line already and removing one set might make it easier to parse
| // If that regex didn't work, try the old regex | ||
| (d) => d?.match(/ to ([^(from)]+) \(.+\)/)?.[1], |
There was a problem hiding this comment.
Might be reading this regex wrong, but are there actual cases where this one would work and the above one would not? All the cases I'm trying, the regex on 83 does a better job
There was a problem hiding this comment.
I only copied over what was there before. I'm not sure which cases this one was supposed to cover.
alec-georgoff
left a comment
alec-georgoff
left a comment
There was a problem hiding this comment.
Would it be worthwhile to also check for "toward [destination]" or "towards [destination]"? Not sure if any of those actually exist but it popped into my head.
@alec-georgoff I added the m in 0deb98a, let me know how that feels! |
Awesome, thanks! |
Description
This PR fixes the display of pattern headsigns for routes with a single pattern and no headsign. The headsign is the name of the last stop in the pattern, and the dropdown selector is not used. The PR also improves display of patterns with leading "To " text.
PR Checklist: